Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally enable fieldalignment linter in govet #2325

Closed
roberthbailey opened this issue Oct 20, 2021 · 0 comments · Fixed by #2795
Closed

Conditionally enable fieldalignment linter in govet #2325

roberthbailey opened this issue Oct 20, 2021 · 0 comments · Fixed by #2795
Assignees
@zmerlynn
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
1.28.0

Comments

@roberthbailey
Copy link
Member

Is your feature request related to a problem? Please describe.
In #2323 we disabled the maligned linter as it has been deprecated. The replacement is govet 'fieldalignment' but turning that on for the whole codebase produces a number of errors.

Describe the solution you'd like
As I mentioned in in #2323 (review) it would be nice to enable the checks on parts of the code base (for structures where we care about memory compaction) but leave some structs (like config structs that are only created once) organized in a more human readable fashion rather than optimizing them for memory usage.

Describe alternatives you've considered
Leave the check disabled.
@roberthbailey roberthbailey added the kind/feature New features for Agones label Oct 20, 2021
@roberthbailey roberthbailey mentioned this issue Oct 20, 2021
Merged
@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. and removed kind/feature New features for Agones labels Oct 20, 2021
@zmerlynn zmerlynn self-assigned this Nov 8, 2022
@zmerlynn zmerlynn mentioned this issue Nov 8, 2022
Merged
@mangalpalli mangalpalli added this to the 1.28.0 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmerlynn zmerlynn

Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.28.0
Development

Successfully merging a pull request may close this issue.

Enable fieldalignment linter, then mostly ignore it zmerlynn/agones
3 participants
@zmerlynn @roberthbailey @mangalpalli