gameserver configurations have no validation on update.

[jeremyje]

Right now there's only validation on creation of a gameserver. If you push a configuration that's invalid like static port with no port numbers via update. Agones will let that through.

[jeremyje]

I have a fix for this already. Discovered when working on #469

[roberthbailey]

@jeremyje - do you still have a fix for this floating around? It'd be nice to get it added in, since I recently ran into this in my testing.

[jeremyje]

No I abandoned the fix. My PR is referenced just above but I doubt it's compatible with what's there now. There's also plenty of edge cases that it doesn't quite work.

[markmandel]

If/when we come back to this, once Player Tracking is in, initialCapacity shouldn't be editable.

See: #1324 (comment) for more context

[markmandel]

Should we close this issue? Hasn't come up again? And it would possibly have performance implications to push GameServer updates through a mutation/validation webhook.

Since it's been a while and seems to be a non-issue for our end users, I'm going to suggest we close this unless anyone objects.

[roberthbailey]

closing sgtm.

[markmandel]

it's been 11 days, with no objections, so closing!