Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD implementation of alpha player tracking #1324

Merged
merged 3 commits into from
Feb 14, 2020
Merged

CRD implementation of alpha player tracking #1324

merged 3 commits into from
Feb 14, 2020

Conversation

markmandel
Copy link
Collaborator

Update to CRD implementation, and pkg/api/gameserver.go and default value implementation.

Work on #1033

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 5, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c56e6f9e-833c-450e-9bc7-993eb7a21fd4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel force-pushed the feature/tracking-crd branch from 5e5cdfa to 024ccca Compare February 5, 2020 23:17
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 58078eb8-44d9-48ff-89ff-5c67c1e631d1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1324/head:pr_1324 && git checkout pr_1324
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-024ccca

@markmandel markmandel force-pushed the feature/tracking-crd branch from 024ccca to c88ab60 Compare February 8, 2020 00:28
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 01e901d1-3351-425e-854e-8cfb316da552

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel force-pushed the feature/tracking-crd branch from c88ab60 to 0fb4380 Compare February 8, 2020 02:21
@markmandel
Copy link
Collaborator Author

Added the feature flag testing -- I had to add some locking to the feature flag implementation because of this. PTAL.

@markmandel markmandel force-pushed the feature/tracking-crd branch from 0fb4380 to de7e157 Compare February 8, 2020 02:27
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8ff298c5-0d2a-4425-9f07-54a30ea752f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 94b646ca-c17d-4e2e-a3c5-7a4e30019089

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2b07a32b-50b8-4e75-a3e3-513920fbda08

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c7e58932-846f-42e7-aa4b-b40570d8701b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 04c103f1-3e22-4d25-9682-eefe1c567829

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1f27487c-d58a-4bae-9ea6-f035e63ff8ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1324/head:pr_1324 && git checkout pr_1324
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-641016f

@markmandel
Copy link
Collaborator Author

This should be good for review again 👍

@markmandel markmandel mentioned this pull request Feb 12, 2020
Merged
roberthbailey
roberthbailey reviewed Feb 13, 2020
View reviewed changes
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7ccaec6b-d142-4948-a942-48fbf2d089cb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
CRD implementation of alpha player tracking
4b4b9f2 
Update to CRD implementation, and pkg/api/gameserver.go and default
value implementation.

Work on googleforgames#1033
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 015f07b0-fd28-496c-869f-13785d138218

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Including feature flag locking.
559230a 
Required to allow tests to pass with race checking enabled.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f387d107-4ad7-4cd0-aac5-f532ad6e8d1a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1324/head:pr_1324 && git checkout pr_1324
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-559230a

@markmandel markmandel mentioned this pull request Feb 14, 2020
Closed
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0939e547-4bed-4bda-b10b-bbe6df568457

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f6286859-0eb6-4816-9baf-2abdfe7850a0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1324/head:pr_1324 && git checkout pr_1324
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-47967ad

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 59a2e43 into googleforgames:master Feb 14, 2020
@markmandel markmandel deleted the feature/tracking-crd branch February 14, 2020 02:40
@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
CRD implementation of alpha player tracking (googleforgames#1324)
9dd3a68 
* CRD implementation of alpha player tracking

Update to CRD implementation, and pkg/api/gameserver.go and default
value implementation.

Work on googleforgames#1033

* Including feature flag locking.

Required to allow tests to pass with race checking enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer left review comments

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@aLekSer aLekSer

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @aLekSer @roberthbailey