Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating code documentation for Labels #2060

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Updating code documentation for Labels #2060

merged 4 commits into from
Apr 15, 2021

Conversation

domgreen
Copy link
Contributor

@domgreen domgreen commented Apr 15, 2021

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Corrects code comments around the prefix that is added by SetLabel and SetAnnotation.

Also changes the SDKMock in go to add the prefix in the tests.

Which issue(s) this PR fixes:

Link to #2057 #2053

Special notes for your reviewer:

You all rock!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 871ff4fe-f4cd-4c78-9b70-6c30b691f21b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2060/head:pr_2060 && git checkout pr_2060
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-ce9dcf3

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an excellent change to me!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domgreen, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9ae3a04f-8c01-4965-aa32-664f4573c500

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2060/head:pr_2060 && git checkout pr_2060
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-1279400

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ae446210-28d2-4d0c-a919-8e9adec8822a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2060/head:pr_2060 && git checkout pr_2060
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-6375be6

@markmandel markmandel merged commit 9f0e89b into googleforgames:main Apr 15, 2021
@markmandel markmandel added this to the 1.14.0 milestone Apr 15, 2021
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 15, 2021
@domgreen domgreen deleted the UnrealLabelDocs branch April 16, 2021 10:26
@roberthbailey roberthbailey added kind/documentation Documentation for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants