-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating code documentation for Labels #2060
Conversation
Build Succeeded 👏 Build Id: 871ff4fe-f4cd-4c78-9b70-6c30b691f21b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an excellent change to me!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: domgreen, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 9ae3a04f-8c01-4965-aa32-664f4573c500 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: ae446210-28d2-4d0c-a919-8e9adec8822a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Corrects code comments around the prefix that is added by SetLabel and SetAnnotation.
Also changes the SDKMock in go to add the prefix in the tests.
Which issue(s) this PR fixes:
Link to #2057 #2053
Special notes for your reviewer:
You all rock!