Generate Certs for Mutation/Validatiion Webhooks #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: 6081f0dd-e859-4fab-93dc-44471ab1826b The following development artifacts have been built, and will exist for the next 30 days:
|
markmandel
reviewed
May 21, 2018
install/helm/README.md
Outdated
| @@ -78,6 +78,7 @@ The following tables lists the configurable parameters of the Agones chart and t | |||
| | `agones.controller.healthCheck.failureThreshold` | Number of times before giving up (in seconds) | `3` | | |||
| | `agones.controller.healthCheck.timeoutSeconds` | Number of seconds after which the probe times out (in seconds) | `1` | | |||
| | `agones.controller.resources` | Controller resource requests/limit | `{}` | |||
| | `agones.controller.generateTls` | Set to true to generate tls certificates or false to provide your own certificates in `certs/*` | `true` | |||
There was a problem hiding this comment.
Small thing, but:
Tls => TLS, since it's an acronym?
|
Just ran through a quick e2e test - all worked great. So outside of the couple of questions above, this LGTM. |
cyriltovena
force-pushed
the
feature/helm-gencerts
branch
from
3223594 to
350642e
Compare
- Add the ability to generate tls cert from helm for webhooks. - By default it's on but you can pass your own certificates. - Target gen-install use our default certificate to stay idempotent - certificates are passed by kubernetes secrets. - Remove certs from controller container (Dockerfile) - Add a target to remove gcloud deployment, usefull to reset - Update helm chart documentation - Generate new install.yaml - update installation documentation
cyriltovena
force-pushed
the
feature/helm-gencerts
branch
from
350642e to
49fcccc
Compare
|
Requested changes are in ! |
|
Build Succeeded 👏 Build Id: 26efb404-923f-499b-a066-b91f23e223bb The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Succeeded 👏 Build Id: 91634ae6-caf9-4568-9f0d-77c9e603464a The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Succeeded 👏 Build Id: 5e8ed247-62a0-484a-a311-94212f88d111 The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Succeeded 👏 Build Id: 5fb6bdc3-98c5-4f83-96fa-1fea41fa1ea2 The following development artifacts have been built, and will exist for the next 30 days:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on GKE !
Closes #169