From 27e81254070dd11edb08653af966ebd9e7b9daf0 Mon Sep 17 00:00:00 2001 From: Mark Mandel Date: Thu, 20 Oct 2022 15:32:51 -0700 Subject: [PATCH 1/2] Updates to release checklist. Adding items that showed up in the recent release that were not written down or required better clarification. --- docs/governance/templates/release_issue.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/governance/templates/release_issue.md b/docs/governance/templates/release_issue.md index 58d59c5e6f..dc51a361b9 100644 --- a/docs/governance/templates/release_issue.md +++ b/docs/governance/templates/release_issue.md @@ -12,8 +12,11 @@ and copy it into a release issue. Fill in relevant values, found inside {} - [ ] Have at least `Editor` level access to `agones-images` project. - [ ] Have permission to publish new versions of the App Engine application. - [ ] Have write access to Agones github repository. -- [ ] Have a `gcloud config configurations` configuration called `agones-images` that points to the same project. +- [ ] Run `git remote -v` and see" + - [ ] An `origin` remote that points to a personal fork of Agones, such as `git@github.com:yourname/agones.git`. + - [ ] An `upstream` remote that points to `git@github.com:googleforgames/agones.git`. - [ ] Have a [Github Personal Access Token](https://github.com/settings/tokens) with repo permissions. +- [ ] Have a `gcloud config configurations` configuration called `agones-images` that points to the same project. - [ ] Edit access to the [Agones Release Calendar](https://calendar.google.com/calendar/u/0?cid=Z29vZ2xlLmNvbV84MjhuOGYxOGhmYnRyczR2dTRoMXNrczIxOEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t) ## Steps @@ -57,7 +60,6 @@ and copy it into a release issue. Fill in relevant values, found inside {} - [ ] If full release, copy `dev_minikube_minor_supported_k8s` to `minikube_minor_supported_k8s`. - [ ] If full release, update documentation with updated example images tags. - [ ] Create PR with these changes, and merge them with an approval. -- [ ] Confirm local git remote `upstream` points at `git@github.com:googleforgames/agones.git` - [ ] Run `git remote update && git checkout main && git reset --hard upstream/main` to ensure your code is in line with upstream (unless this is a hotfix, then do the same, but for the release branch) - [ ] Publish SDK packages @@ -73,6 +75,7 @@ and copy it into a release issue. Fill in relevant values, found inside {} (`helm install --namespace=agones-system agones agones/agones --version={version}-rc` if release candidate) and a smoke test to confirm everything is working. - [ ] Attach all assets found in the `release` folder to the draft Github Release. - [ ] If release candidate check the pre-release box on the draft Github Release +- [ ] Copy any review changes to the release blog post are copied into the draft Github release. - [ ] Publish the draft Github Release. - [ ] Send an email to the [mailing list][list] with the release details (copy-paste the release blog post) - [ ] Paste the announcement blog post to the #users Slack group. From 269afe181d8cd8ec26de01f3c1e642e5add3346e Mon Sep 17 00:00:00 2001 From: Mark Mandel Date: Fri, 21 Oct 2022 12:02:54 -0700 Subject: [PATCH 2/2] Review updates, and some other small tweaks. --- docs/governance/templates/release_issue.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/governance/templates/release_issue.md b/docs/governance/templates/release_issue.md index dc51a361b9..1cc687ddae 100644 --- a/docs/governance/templates/release_issue.md +++ b/docs/governance/templates/release_issue.md @@ -11,11 +11,11 @@ and copy it into a release issue. Fill in relevant values, found inside {} - [ ] Have at least `Editor` level access to `agones-images` project. - [ ] Have permission to publish new versions of the App Engine application. -- [ ] Have write access to Agones github repository. -- [ ] Run `git remote -v` and see" +- [ ] Have write access to Agones GitHub repository. +- [ ] Run `git remote -v` and see: - [ ] An `origin` remote that points to a personal fork of Agones, such as `git@github.com:yourname/agones.git`. - [ ] An `upstream` remote that points to `git@github.com:googleforgames/agones.git`. -- [ ] Have a [Github Personal Access Token](https://github.com/settings/tokens) with repo permissions. +- [ ] Have a [GitHub Personal Access Token](https://github.com/settings/tokens) with repo permissions. - [ ] Have a `gcloud config configurations` configuration called `agones-images` that points to the same project. - [ ] Edit access to the [Agones Release Calendar](https://calendar.google.com/calendar/u/0?cid=Z29vZ2xlLmNvbV84MjhuOGYxOGhmYnRyczR2dTRoMXNrczIxOEBncm91cC5jYWxlbmRhci5nb29nbGUuY29t) @@ -36,7 +36,7 @@ and copy it into a release issue. Fill in relevant values, found inside {} - For example, if you are creating the 1.18.0 release, then you would deploy the 1-17-0 service (release minus one, and then replace dots with dashes). - [ ] Run `make gen-changelog` to generate the CHANGELOG.md (if release candidate `make gen-changelog RELEASE_VERSION={version}-rc`). You will need your - [Github Personal Access Token](https://github.com/settings/tokens) for this. + [GitHub Personal Access Token](https://github.com/settings/tokens) for this. - [ ] Ensure the [helm `tag` value][values] is correct (should be {version} if a full release, {version}-rc if release candidate) - [ ] Ensure the [helm `Chart` version values][chart] are correct (should be {version} if a full release, {version}-rc if release candidate) - [ ] Update SDK Package Versions @@ -73,13 +73,13 @@ and copy it into a release issue. Fill in relevant values, found inside {} version is available via the command `helm search repo agones --versions --devel`. - [ ] Do a `helm install --namespace=agones-system agones agones/agones` (`helm install --namespace=agones-system agones agones/agones --version={version}-rc` if release candidate) and a smoke test to confirm everything is working. -- [ ] Attach all assets found in the `release` folder to the draft Github Release. -- [ ] If release candidate check the pre-release box on the draft Github Release -- [ ] Copy any review changes to the release blog post are copied into the draft Github release. -- [ ] Publish the draft Github Release. -- [ ] Send an email to the [mailing list][list] with the release details (copy-paste the release blog post) +- [ ] Attach all assets found in the `release` folder to the draft GitHub Release. +- [ ] If release candidate check the pre-release box on the draft GitHub Release +- [ ] Copy any review changes from the release blog post into the draft GitHub release. +- [ ] Publish the draft GitHub Release. +- [ ] Email the [mailing list][list] with the release details (copy-paste the release blog post). - [ ] Paste the announcement blog post to the #users Slack group. -- [ ] Post to the [agonesdev](https://twitter.com/agonesdev) twitter account. +- [ ] Post to the [agonesdev](https://twitter.com/agonesdev) Twitter account. - [ ] If full release, run `git checkout main`. - [ ] If full release, then increment the `base_version` in [`build/Makefile`][build-makefile] - [ ] If full release move [helm `tag` value][values] is set to {version}+1-dev