Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linting into it's own serial step #311

Merged
merged 1 commit into from
Jul 31, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ build-images: build-controller-image build-agones-sdk-image
build-sdks: build-sdk-cpp

# Run all tests
test: ensure-build-image lint test-go test-install-yaml
test: ensure-build-image test-go test-install-yaml

# Run go tests
test-go:
Expand Down Expand Up @@ -257,7 +257,7 @@ do-release: RELEASE_VERSION ?= $(base_version)
do-release:
@echo "Starting release for version: $(RELEASE_VERSION)"
git checkout -b release-$(RELEASE_VERSION)
$(MAKE) test
$(MAKE) lint test
-rm -rf $(agones_path)/release
mkdir $(agones_path)/release
docker run --rm $(common_mounts) -w $(mount_path)/sdks/cpp $(build_tag) make clean
Expand Down
9 changes: 6 additions & 3 deletions cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,19 @@ steps:
- name: "make-docker"
dir: "build"
args: ["pull-build-image"] # pull the build image if it exists
id: pull-build-image
- name: "make-docker"
dir: "build"
args: ["lint"] # pull the build image if it exists
id: lint
- name: "make-docker"
dir: "build"
args: [ "test" ] # run tests
waitFor: ['pull-build-image']
waitFor: ['lint']
id: tests
- name: "make-docker"
dir: "build"
args: [ "build", "push" ] # build all the things, and push images
waitFor: ['pull-build-image']
waitFor: ['lint']
id: build
- name: 'gcr.io/cloud-builders/gsutil'
dir: "sdks/cpp/bin"
Expand Down