Guidelines on how to test developer changes to Agones #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The developer guide didn't cover what to do "next" after compiling Agones -- i.e. how to make changes and test them. This PR is an effort to fix this. Since googleforgames#309 is completed, you don't have to manually delete the agones-controller pod, so this also becomes much simpler. Closes googleforgames#308
markmandel
added
kind/documentation
|
/cc @victor-prodan does this cover all the things you were thinking? |
|
Build Failed 😱 Build Id: 8c789fad-959c-4be2-898e-2f30d0ab477a Build Logs |
|
Build Failed 😱 Build Id: fd32cca0-6477-4a04-adfb-8cc5de97b1bc Build Logs |
|
Build Succeeded 👏 Build Id: cafbd871-5439-4b50-a752-44f31d97d57e The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
cyriltovena
reviewed
Sep 7, 2018
| 3. Push the image you built to it | ||
| 4. Install your version (replacing the current one, if there is one) | ||
|
|
||
| You can now test your changes by hand, but also can run `make e2e-test` to run the automated tests as well |
|
I would also suggest adding a section "Running a custom test cluster" , explaining what must be done if you want to use a different repo/k8s provider:
|
|
@victor-prodan I don't run a custom cluster 😄 but this would be a good addition. Would love a PR from someone who has done this! Maybe it's something we can support better in our tooling? |
|
Yes, I'll look into that |
|
Build Succeeded 👏 Build Id: a49e7cbc-d08f-4fde-916e-2eee049f725d The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The developer guide didn't cover what to do "next" after compiling Agones -- i.e. how to make changes and test them.
This PR is an effort to fix this. Since #309 is completed, you don't have to manually delete the agones-controller pod, so this also becomes much simpler.
Closes #308