Ports should always be allocated to a GameServer #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocator was written before we have the autoscaler, which has a requirement to be able to start GameServers past the current number of nodes, so that the autoscaler can find room for them automaticaly. The previous port allocator would only allow port ranges for each current node - but this PR will allow it to go past that, and dynamically add port ranges as required. This also removes the requirement to do a full `GameServer` port sync every time a Node gets removed, and drops a somewhat lengthy locking process.
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: 8791a01e-e4eb-4284-b531-914d5b99b7ec The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
EricFortin
approved these changes
Nov 13, 2018
|
Build Failed 😱 Build Id: 133a7fb1-26d4-457c-b18f-e9255b871d0a Build Logs |
|
Build Succeeded 👏 Build Id: 6fdf0dda-cfeb-458c-9b25-3aa5191ee842 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocator was written before we have the autoscaler, which has a requirement to be able to start GameServers past the current number of nodes, so that the autoscaler can find room for them automaticaly.
The previous port allocator would only allow port ranges for each current node - but this PR will allow it to go past that, and dynamically add port ranges as required.
This also removes the requirement to do a full
GameServerport sync every time a Node gets removed, and drops a somewhat lengthy locking process.