Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinger service for Multiple Cluster Latency Measurement. #434

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

markmandel
Copy link
Collaborator

Context: #301

This creates a simple HTTP endpoint and/or a rate limited UDP echo service to be able to easily do RTT latency tests from game clients, to multiple Agones installs.

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Dec 1, 2018
@markmandel markmandel added this to the 0.7.0 milestone Dec 1, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b9a31395-226f-483b-85c7-9174c93f26ee

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/434/head:pr_434 && git checkout pr_434
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-2cdda86

// See the License for the specific language governing permissions and
// limitations under the License.

package main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enocom can I get a sanity check here please? 😄

This is a pretty self contained binary, so I left everything in the main package.

Good? Bad? Otherwise?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the beauty of Go -- small and focused when it needs to be. I think this looks good.

Context: googleforgames#301

This creates a simple HTTP endpoint and/or a rate limited UDP echo service
to be able to easily do RTT latency tests from game clients, to multiple
Agones installs.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0fb0c305-a05f-425e-a2ff-b1b2315d37d5

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/434/head:pr_434 && git checkout pr_434
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-3c997e1

1 similar comment
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0fb0c305-a05f-425e-a2ff-b1b2315d37d5

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/434/head:pr_434 && git checkout pr_434
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-3c997e1

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, LGTM

@markmandel markmandel merged commit c10f834 into googleforgames:master Dec 6, 2018
@markmandel markmandel deleted the feature/ping branch December 6, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants