Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GameServer Status Subresource #619

Closed
wants to merge 6 commits into from
Closed

Introduce GameServer Status Subresource #619

wants to merge 6 commits into from

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 22, 2019

Switch to using UpdateStatus() function where GameServer Status is changed.
Now Updates on main Gameserver Resource endpoint does not change Status.
Moved Initial Status setting out of Creation Mutation Handler to Sync function.

Is needed for #150 ticket.
This is Work In Progress. Do we need to move Labels and Annotations from GameServer Spec to Status? Then we can actually

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3809bdf5-599e-400b-b15e-99cbd22a0912

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 296f63ee-89d1-4d08-8740-8e2457f70a9f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9870c9af-c2e2-46f3-89c6-493f0f8b038e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Feb 25, 2019

Strange error on deploy-site-static step:

descriptor:      [/workspace/go/src/site/.app.yaml]
source:          [/workspace/go/src/site]
target project:  [agones-images]
target service:  [preview]
target version:  [0076faa]
target url:      [https://0076faa-dot-preview-dot-agones-images.appspot.com]

...
Beginning deployment of service [preview]...
#============================================================#
#= Uploading 58 files to Google Cloud Storage               =#
#============================================================#
File upload done.
ERROR: (gcloud.app.deploy) INVALID_ARGUMENT: Your app may not have more than 210 versions. Please delete one of the existing versions before trying to create a new version.

I will trigger a rebuild soon.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7dcbd691-f53b-47c0-99f2-3d3995beac52

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c68b0cc3-5ad3-4d27-a631-9909908d19be

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Mar 26, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 3, 2019
@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Apr 12, 2019
@aLekSer aLekSer force-pushed the sdk-update-status branch from 8360197 to bb362c1 Compare April 29, 2019 11:51
aLekSer added 5 commits April 29, 2019 14:52
@aLekSer
Changing SDK server
29583e5
@aLekSer
Adding Status subresource for Gameserver CRD
7e1ea00 
Regular Update() function is not changing state after this change.
Broking change: now gameservers is not working as usual
@aLekSer
Fixed Portallocation and Fleetallocation
65da5a7 
Need to work on GameserverAllocation, clean the code and fix E2E tests.
@aLekSer
Add updateStatus only when there is not Status
e8bbd87 
Needs to make refactoring, also Allocation should be fixed, E2E tests
are failing.
@aLekSer
Perform code cleanup
7d8d9b8 
GameServerAllocations are left.
@aLekSer aLekSer force-pushed the sdk-update-status branch from bb362c1 to 3fa8c2b Compare April 29, 2019 11:52
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e4bcd036-454a-429e-8430-aad678091508

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 70d8d5dd-19e2-40c3-95e1-4e92fb34b290

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer force-pushed the sdk-update-status branch from 3fa8c2b to b9584b5 Compare April 29, 2019 12:09
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 00d3d352-61ec-4556-93d9-fd63e70172f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Fix for GameServerAllocation
7c06dac 
Add version annotation. Now all E2E tests pass. Some fluctuation on
SDKSetAnnotation.
@aLekSer aLekSer force-pushed the sdk-update-status branch from b9584b5 to 7c06dac Compare April 29, 2019 12:25
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8e86d458-0a95-450d-8c35-1adfd574fa58

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel modified the milestones: 0.10.0, 0.11.0 May 7, 2019
@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label May 8, 2019
@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels May 16, 2019
@markmandel markmandel modified the milestones: 0.11.0, 0.12.0 Jun 18, 2019
@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 18, 2019
@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Jun 25, 2019
@markmandel
Copy link
Collaborator

@aLekSer I assume you don't have any issue with taking this over?

@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 22, 2019

Yes, I stuck with this PR. I can help on this if I found what goes wrong with new version of Kubernetes.

@markmandel
Copy link
Collaborator

No worries. I'm on it. There are some interesting problems that need solving on this one. Working through them. Do you mind if I close this PR?

@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 23, 2019

@markmandel take over this PR
I have made a copy of the branch rebased on latest master, it could be found here

@aLekSer aLekSer closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aLekSer @agones-bot @markmandel