Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a minor typo #701

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Fixed a minor typo #701

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2940c4
Fixed typo
pooneh-m Apr 11, 2019
d482696
Merge branch 'master' into bugfix
markmandel Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/governance/templates/release_issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ and copy it into a release issue. Fill in relevent values, found inside {}
- [ ] Copy the draft release content into a new `/site/content/en/blog/releases` content (this will be what you send via email).
- [ ] Create PR with these changes, and merge them with approval
- [ ] Confirm local git remote `upstream` points at `[email protected]:GoogleCloudPlatform/agones.git`
- [ ] Run `git remote update && git checkout master && git reset --hard upstream/master` to ensure your code is in line with upstream (unless this is a hotfix, then do the same, but for the the release branch)
- [ ] Run `git remote update && git checkout master && git reset --hard upstream/master` to ensure your code is in line with upstream (unless this is a hotfix, then do the same, but for the release branch)
- [ ] Run `make do-release`. (if release candidate: `make do-release RELEASE_VERSION={version}-rc`) to create and push the docker images and helm chart.
- [ ] Do a `helm repo add agones https://agones.dev/chart/stable` and verify that the new version is available via the command `helm search agones/`
- [ ] Do a `helm install` and a smoke test to confirm everything is working.
Expand All @@ -49,4 +49,4 @@ and copy it into a release issue. Fill in relevent values, found inside {}
[chart]: https://github.com/GoogleCloudPlatform/agones/blob/master/install/helm/agones/Chart.yaml
[list]: https://groups.google.com/forum/#!forum/agones-discuss
[release-template]: https://github.com/GoogleCloudPlatform/agones/blob/master/docs/governance/templates/release.md
[build-makefile]: https://github.com/GoogleCloudPlatform/agones/blob/master/build/Makefile
[build-makefile]: https://github.com/GoogleCloudPlatform/agones/blob/master/build/Makefile
2 changes: 1 addition & 1 deletion pkg/apis/stable/v1alpha1/gameserverallocation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ type GameServerAllocationSpec struct {
MetaPatch MetaPatch `json:"metadata,omitempty"`
}

// PreferredSelectors converts all the the preferred label selectors into an array of
// PreferredSelectors converts all the preferred label selectors into an array of
// labels.Selectors. This is useful as they all have `Match()` functions!
func (gsas *GameServerAllocationSpec) PreferredSelectors() ([]labels.Selector, error) {
list := make([]labels.Selector, len(gsas.Preferred))
Expand Down