Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote autoscaling to v1 #874

Merged
merged 7 commits into from
Jul 9, 2019

Conversation

roberthbailey
Copy link
Member

@roberthbailey roberthbailey commented Jul 5, 2019

This is part of #703.

I didn't update agones_crd_api_reference.html because I was hoping that there is an automated way to do it that I haven't yet found (although the presence of {{% feature expiryVersion="0.10.0" %}} at the top of the file makes me think I may have unfounded hope...).

I also fixed some import naming as suggested by @pooneh-m in #829 to try and clean up some tech debt while I was at it.

/assign @markmandel

/label kind/breaking

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ea9de890-036f-4a9c-9a96-6e4dbb54c808

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Jul 5, 2019

Hello @roberthbailey let me check what have happened with agones_crd_api_reference.html.

@aLekSer
Copy link
Collaborator

aLekSer commented Jul 5, 2019

Verified on your branch - all is fine with make gen-api-docs. However I think we could remove outdated versions with expiryVersion < current version - 1 minor version.
Produced a fix for generation process, removed annoying old versions:
#877

@roberthbailey
Copy link
Member Author

Thanks @aLekSer! Once #877 goes in I will re-generate API docs. In the mean time I'll try to get all of the presubmit tests passing.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fb5449bf-6c86-4a5c-992a-c2c1107ef445

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 78c5af59-5c35-4ca7-b756-fd0421f74190

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

roberthbailey commented Jul 7, 2019

@markmandel - it looks like the e2e test uses helm upgrade which as expected fails since I've changed api groups. Doing a fresh helm install with

helm install --name autoscaling-v1 --namespace agones-system agones --set agones.image.tag=0.12.0-097a5ea,agones.image.registry=gcr.io/agones-images

on a new cluster worked for me, so I'm guessing that someone with admin access to the agones-images will need to modify the cluster used by cloud build for e2e testing to delete the existing helm install so a fresh one will succeed.

It looks like in #829 you did a helm delete agones -purge at one point, but it isn't clear if that was necessary for tests to pass or not.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2d8268a6-6210-4ca4-94ce-3b143f4016e8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c2232a41-2fd4-4103-80bf-493ad89e1670

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Jul 8, 2019
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - happy to approve it 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: adeec71a-b0e3-4007-aa00-8624bfadf973

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/874/head:pr_874 && git checkout pr_874
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-61ac72d

@markmandel markmandel merged commit 176dd17 into googleforgames:master Jul 9, 2019
@markmandel markmandel added the kind/breaking Breaking change label Jul 9, 2019
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@roberthbailey roberthbailey deleted the autoscaling-to-v1 branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/breaking Breaking change kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants