-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote autoscaling to v1 #874
Promote autoscaling to v1 #874
Conversation
Build Failed 😱 Build Id: ea9de890-036f-4a9c-9a96-6e4dbb54c808 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Hello @roberthbailey let me check what have happened with |
Verified on your branch - all is fine with |
b83f3a0
to
5a8232f
Compare
Build Failed 😱 Build Id: fb5449bf-6c86-4a5c-992a-c2c1107ef445 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
5a8232f
to
097a5ea
Compare
Build Failed 😱 Build Id: 78c5af59-5c35-4ca7-b756-fd0421f74190 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
@markmandel - it looks like the e2e test uses
on a new cluster worked for me, so I'm guessing that someone with admin access to the It looks like in #829 you did a |
097a5ea
to
6bc3dfc
Compare
Build Failed 😱 Build Id: 2d8268a6-6210-4ca4-94ce-3b143f4016e8 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
6bc3dfc
to
61ac72d
Compare
Build Failed 😱 Build Id: c2232a41-2fd4-4103-80bf-493ad89e1670 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - happy to approve it 👍
Build Succeeded 👏 Build Id: adeec71a-b0e3-4007-aa00-8624bfadf973 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This is part of #703.
I didn't update agones_crd_api_reference.html because I was hoping that there is an automated way to do it that I haven't yet found (although the presence of
{{% feature expiryVersion="0.10.0" %}}
at the top of the file makes me think I may have unfounded hope...).I also fixed some import naming as suggested by @pooneh-m in #829 to try and clean up some tech debt while I was at it.
/assign @markmandel
/label kind/breaking