Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Installation Docs and example GS configuration #962

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jul 30, 2019

Now we have 6 pods in agones-system namespace, not one as per docs.
There was an issue in PortPolicy and image tag.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb5e2b78-b248-4a67-97ae-27a9e1e17983

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/962/head:pr_962 && git checkout pr_962
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-69ff85e

@roberthbailey
Copy link
Member

According to https://agones.dev/site/docs/examples/ these aren't supposed to be working examples:

"These examples are for reference only. They are not backed by working images."

I'd be happy to make them workable, but if we do we should update the docs too (and make them all work).

We now have 6 pods in agones-system namespace.
There was an issue in PortPolicy and image tag.
@aLekSer aLekSer force-pushed the fix/example-gs-yaml branch from 69ff85e to be782d1 Compare July 30, 2019 16:34
@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 30, 2019

@roberthbailey
Regarding the configuration, someone as I did could think they are working.
The most problem is that in comments section we read that Dynamic and HostPort could not defined at the same time. And then we define them both - which is mutually exclusive lines and bad configuration.
Note that I added fix of documentation here. PTAL again.

@aLekSer aLekSer changed the title Fix invalid example GS configuration Fix Installation Docs and example GS configuration Jul 30, 2019
@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 30, 2019

By the way I can leave not working image and correct only PortPolicy.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9cdeded8-f151-4b7b-bfab-88de0646edd8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/962/head:pr_962 && git checkout pr_962
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-be782d1

@roberthbailey
Copy link
Member

Regarding the configuration, someone as I did could think they are working.

I agree. I found it confusing as well.

@markmandel
Copy link
Collaborator

I've no strong opinions on leaving them as broken images - if you both feel strongly they should be working images, then lets make them all working configurations 👍 not just gameservers, but fleet.yaml, etc.

Sound good?

@roberthbailey
Copy link
Member

I think it'd be nice to have them all working. It should be relatively easy to do so, and to update the docs to remove the note about them being non-functional.

@markmandel
Copy link
Collaborator

Sounds good to me. Do we want to include it in this PR, or make a new one?

@roberthbailey
Copy link
Member

There isn't a good reason not to split it among multiple PRs so we can get this one in. I've created #969 with a checklist for the files in question (I think some of them are already ok, so we can just verify those and fix the others).

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@roberthbailey
Copy link
Member

Part of #969.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a4bab6ab-85f0-4f9a-be7a-7be4ef31ce34

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/962/head:pr_962 && git checkout pr_962
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-74e1558

@markmandel markmandel merged commit f95c376 into googleforgames:master Jul 31, 2019
@markmandel markmandel added this to the 0.12.0 milestone Aug 1, 2019
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants