-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Installation Docs and example GS configuration #962
Fix Installation Docs and example GS configuration #962
Conversation
Build Succeeded 👏 Build Id: fb5e2b78-b248-4a67-97ae-27a9e1e17983 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
According to https://agones.dev/site/docs/examples/ these aren't supposed to be working examples: "These examples are for reference only. They are not backed by working images." I'd be happy to make them workable, but if we do we should update the docs too (and make them all work). |
We now have 6 pods in agones-system namespace. There was an issue in PortPolicy and image tag.
69ff85e
to
be782d1
Compare
@roberthbailey |
By the way I can leave not working image and correct only PortPolicy. |
Build Succeeded 👏 Build Id: 9cdeded8-f151-4b7b-bfab-88de0646edd8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
I agree. I found it confusing as well. |
I've no strong opinions on leaving them as broken images - if you both feel strongly they should be working images, then lets make them all working configurations 👍 not just gameservers, but fleet.yaml, etc. Sound good? |
I think it'd be nice to have them all working. It should be relatively easy to do so, and to update the docs to remove the note about them being non-functional. |
Sounds good to me. Do we want to include it in this PR, or make a new one? |
There isn't a good reason not to split it among multiple PRs so we can get this one in. I've created #969 with a checklist for the files in question (I think some of them are already ok, so we can just verify those and fix the others). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Part of #969. |
Build Succeeded 👏 Build Id: a4bab6ab-85f0-4f9a-be7a-7be4ef31ce34 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Now we have 6 pods in agones-system namespace, not one as per docs.
There was an issue in PortPolicy and image tag.