Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double declaration of Variant class and it const values #324

Open
samanvp opened this issue Aug 10, 2018 · 0 comments
Open

Double declaration of Variant class and it const values #324

samanvp opened this issue Aug 10, 2018 · 0 comments
Assignees

Comments

@samanvp
Copy link
Contributor

samanvp commented Aug 10, 2018

In PR #322 we moved a couple of const values (namely: MISSING_FIELD_VALUE, PASS_FILTER, END_INFO_KEY, GENOTYPE_FORMAT_KEY, PHASESET_FORMAT_KEY, DEFAULT_PHASESET_VALUE, MISSING_GENOTYPE_VALUE) and classes (MalformedVcfRecord, Variant, VariantCall) from vcfio.py to vcf_parser.py.

The reason was that we wanted to avoid circular imports which made it impossible to run the code because vcfio.py imported vcfio_parser.py and vice versa.

However, since these const values and classes are accessed via vcfio.py by the rest of the code, we redeclared them in vcfio.py to avoid changing the current settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant