Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nucleus' protos instead of VcfHeader #422

Open
arostamianfar opened this issue Nov 26, 2018 · 0 comments
Open

Use Nucleus' protos instead of VcfHeader #422

arostamianfar opened this issue Nov 26, 2018 · 0 comments

Comments

@arostamianfar
Copy link
Contributor

Nucleus VcfHeader protos are much nicer to work with than our VcfHeader class. We should update the code to use the protos. Need to first resolve #420.

Important note: we should make sure that there are no performance penalties when switching to use protos as protos are known to be less performant than native python objects. Given that we use headers mostly during initialization, then it likely won't have a noticeable effect. The only exception is in the ProcessedVariant class when checking for Number=A and some annotation fields. Proto lookups can be avoided by just creating an auxiliary map ({key, number}) inside that class.

@arostamianfar arostamianfar changed the title Use Nucleus's protos instead of VcfHeader Use Nucleus' protos instead of VcfHeader Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant