Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapViewCallbacks onMarkerClick triggers onMapReady #321

Closed
liuyongAlive opened this issue Nov 1, 2024 · 0 comments · Fixed by #322
Closed

MapViewCallbacks onMarkerClick triggers onMapReady #321

liuyongAlive opened this issue Nov 1, 2024 · 0 comments · Fixed by #322
Assignees
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@liuyongAlive
Copy link

liuyongAlive commented Nov 1, 2024

Environment details

  1. MapViewCallbacks onMarkerClick triggers onMapReady,not onMarkClick
  2. Android & react-nnative-navigation-sdk v0.8.0

Steps to reproduce

1 using MapViewCallbacks onMarkerClick

Code example

onMapReady: () => {
     // click marker still output this
    console.log("onMapReady", mapViewController);
  },

onMarkerClick: (marker) => {
    // click marker not work
    if (marker) {
      console.log("onMarkerClick", marker);
    }
  },

Stack trace

# example

I'm not very good at java, and I suspect it's a mistake in this place.

public void onMarkerClick(Marker marker) {
emitEvent("onMapReady", ObjectTranslationUtil.getMapFromMarker(marker));
}

as the same, I think this has same mistake

@Override
public void onMarkerInfoWindowTapped(Marker marker) {
emitEvent("onInfoWindowClick", ObjectTranslationUtil.getMapFromMarker(marker));
}

@liuyongAlive liuyongAlive added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 1, 2024
@jokerttu jokerttu added priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed triage me I really want to be triaged. labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants