'pip install watchdog' fails on macOS 10.15.2 Catalina #620
Comments
|
Could you alter the |
|
On macOS 10.11.6 there is a similar problem (with Python 3.8.1): Obtaining file:///Users/keimlink/projects/watchdog
Requirement already satisfied: pathtools>=0.1.1 in ./.venv/lib/python3.8/site-packages (from watchdog==0.10.0) (0.1.2)
Requirement already satisfied: pyobjc-framework-Cocoa>=4.2.2 in ./.venv/lib/python3.8/site-packages (from watchdog==0.10.0) (6.1)
Requirement already satisfied: pyobjc-framework-FSEvents>=4.2.2 in ./.venv/lib/python3.8/site-packages (from watchdog==0.10.0) (6.1)
Requirement already satisfied: PyYAML>=3.10 in ./.venv/lib/python3.8/site-packages (from watchdog==0.10.0) (5.3)
Requirement already satisfied: argh>=0.24.1 in ./.venv/lib/python3.8/site-packages (from watchdog==0.10.0) (0.26.2)
Requirement already satisfied: pyobjc-core>=6.1 in ./.venv/lib/python3.8/site-packages (from pyobjc-framework-Cocoa>=4.2.2->watchdog==0.10.0) (6.1)
Installing collected packages: watchdog
Found existing installation: watchdog 0.10.0
Uninstalling watchdog-0.10.0:
Successfully uninstalled watchdog-0.10.0
Running setup.py develop for watchdog
ERROR: Command errored out with exit status 1:
command: /Users/keimlink/projects/watchdog/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/keimlink/projects/watchdog/setup.py'"'"'; __file__='"'"'/Users/keimlink/projects/watchdog/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
cwd: /Users/keimlink/projects/watchdog/
Complete output (59 lines):
running develop
running egg_info
writing src/watchdog.egg-info/PKG-INFO
writing dependency_links to src/watchdog.egg-info/dependency_links.txt
writing entry points to src/watchdog.egg-info/entry_points.txt
writing requirements to src/watchdog.egg-info/requires.txt
writing top-level names to src/watchdog.egg-info/top_level.txt
reading manifest file 'src/watchdog.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.h' under directory 'src'
writing manifest file 'src/watchdog.egg-info/SOURCES.txt'
running build_ext
building '_watchdog_fsevents' extension
creating build
creating build/temp.macosx-10.11-x86_64-3.8
creating build/temp.macosx-10.11-x86_64-3.8/src
ccache /usr/bin/cc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -DWATCHDOG_VERSION_STRING="0.10.0" -DWATCHDOG_VERSION_MAJOR=0 -DWATCHDOG_VERSION_MINOR=10 -DWATCHDOG_VERSION_BUILD=0 -I/Users/keimlink/projects/watchdog/.venv/include -I/Users/keimlink/.pyenv/versions/3.8.1/include/python3.8 -c src/watchdog_fsevents.c -o build/temp.macosx-10.11-x86_64-3.8/src/watchdog_fsevents.o -std=c99 -pedantic -Wall -Werror -Wextra -fPIC -Wno-error=unused-command-line-argument
src/watchdog_fsevents.c:196:28: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if (((callback_result) == ((void*)0)))
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:196:28: note: remove extraneous parentheses around the comparison to silence this warning
if (((callback_result) == ((void*)0)))
~ ^ ~
src/watchdog_fsevents.c:196:28: note: use '=' to turn this equality comparison into an assignment
if (((callback_result) == ((void*)0)))
^~
=
src/watchdog_fsevents.c:376:18: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if (((value) == ((void*)0)))
~~~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:376:18: note: remove extraneous parentheses around the comparison to silence this warning
if (((value) == ((void*)0)))
~ ^ ~
src/watchdog_fsevents.c:376:18: note: use '=' to turn this equality comparison into an assignment
if (((value) == ((void*)0)))
^~
=
src/watchdog_fsevents.c:434:18: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if (((value) == ((void*)0)))
~~~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:434:18: note: remove extraneous parentheses around the comparison to silence this warning
if (((value) == ((void*)0)))
~ ^ ~
src/watchdog_fsevents.c:434:18: note: use '=' to turn this equality comparison into an assignment
if (((value) == ((void*)0)))
^~
=
src/watchdog_fsevents.c:501:18: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if (((value) == ((void*)0))) {
~~~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:501:18: note: remove extraneous parentheses around the comparison to silence this warning
if (((value) == ((void*)0))) {
~ ^ ~
src/watchdog_fsevents.c:501:18: note: use '=' to turn this equality comparison into an assignment
if (((value) == ((void*)0))) {
^~
=
4 errors generated.
error: command 'ccache' failed with exit status 1
----------------------------------------
Rolling back uninstall of watchdog
Moving to /Users/keimlink/projects/watchdog/.venv/bin/watchmedo
from /private/var/folders/0h/m440_ddd4qv8ps6hg0pfxnbm0000gn/T/pip-uninstall-dnnqcrg7/watchmedo
Moving to /Users/keimlink/projects/watchdog/.venv/lib/python3.8/site-packages/watchdog.egg-link
from /private/var/folders/0h/m440_ddd4qv8ps6hg0pfxnbm0000gn/T/pip-uninstall-v8maatdz/watchdog.egg-link
ERROR: Command errored out with exit status 1: /Users/keimlink/projects/watchdog/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/keimlink/projects/watchdog/setup.py'"'"'; __file__='"'"'/Users/keimlink/projects/watchdog/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.I could fix it with this change: diff --git a/setup.py b/setup.py
index 59f54f3..8fc6255 100644
--- a/setup.py
+++ b/setup.py
@@ -62,6 +62,7 @@ if get_platform().startswith('macosx'):
'-Wall',
'-Werror',
'-Wextra',
+ '-Wno-parentheses-equality',
'-fPIC',
# required w/Xcode 5.1+ and above because of '-mno-fused-madd'But removing diff --git a/setup.py b/setup.py
index 59f54f3..0849565 100644
--- a/setup.py
+++ b/setup.py
@@ -60,7 +60,6 @@ if get_platform().startswith('macosx'):
'-std=c99',
'-pedantic',
'-Wall',
- '-Werror',
'-Wextra',
'-fPIC',
Since I have no experience with C I'm unable to tell which is the right way to fix this. |
|
I wonder why this is the first time someone reports those issues 🤔 |
|
I will simply fix the code, thanks for the report @keimlink :) |
|
@keimlink could you try to install the version from that branch: https://github.com/gorakhargosh/watchdog/tree/fix-use-sys-platform? |
|
Unfortunately the problem still exists in the Complete output: Obtaining file:///Users/keimlink/projects/watchdog
Collecting pathtools>=0.1.1 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/e7/7f/470d6fcdf23f9f3518f6b0b76be9df16dcc8630ad409947f8be2eb0ed13a/pathtools-0.1.2.tar.gz
Collecting pyobjc-framework-Cocoa>=4.2.2 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/7f/fa/5b2f6ae289e98471676dde3887b7d78f5166cbd7bd99943506abd76b2bd0/pyobjc_framework_Cocoa-6.1-cp38-cp38-macosx_10_9_x86_64.whl
Collecting pyobjc-framework-FSEvents>=4.2.2 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/1f/2c/18237d753ca6a4f6e09e043941aafd244c047c27dfd544e8dd1a71d800eb/pyobjc_framework_FSEvents-6.1-cp38-cp38-macosx_10_9_x86_64.whl
Collecting PyYAML>=3.10 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/3d/d9/ea9816aea31beeadccd03f1f8b625ecf8f645bd66744484d162d84803ce5/PyYAML-5.3.tar.gz
Collecting argh>=0.24.1 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/06/1c/e667a7126f0b84aaa1c56844337bf0ac12445d1beb9c8a6199a7314944bf/argh-0.26.2-py2.py3-none-any.whl
Collecting pyobjc-core>=6.1 (from pyobjc-framework-Cocoa>=4.2.2->watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/73/2c/e90c0bb97a455bfe1ec7f8ad6ddfdd8fe55ece448566487242354a4401f6/pyobjc_core-6.1-cp38-cp38-macosx_10_9_x86_64.whl
Installing collected packages: pathtools, pyobjc-core, pyobjc-framework-Cocoa, pyobjc-framework-FSEvents, PyYAML, argh, watchdog
Running setup.py install for pathtools ... done
Running setup.py install for PyYAML ... done
Running setup.py develop for watchdog
ERROR: Command errored out with exit status 1:
command: /Users/keimlink/projects/watchdog/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/keimlink/projects/watchdog/setup.py'"'"'; __file__='"'"'/Users/keimlink/projects/watchdog/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
cwd: /Users/keimlink/projects/watchdog/
Complete output (59 lines):
running develop
running egg_info
writing src/watchdog.egg-info/PKG-INFO
writing dependency_links to src/watchdog.egg-info/dependency_links.txt
writing entry points to src/watchdog.egg-info/entry_points.txt
writing requirements to src/watchdog.egg-info/requires.txt
writing top-level names to src/watchdog.egg-info/top_level.txt
reading manifest file 'src/watchdog.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.h' under directory 'src'
writing manifest file 'src/watchdog.egg-info/SOURCES.txt'
running build_ext
building '_watchdog_fsevents' extension
creating build
creating build/temp.macosx-10.11-x86_64-3.8
creating build/temp.macosx-10.11-x86_64-3.8/src
ccache /usr/bin/cc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -DWATCHDOG_VERSION_STRING="0.10.1" -DWATCHDOG_VERSION_MAJOR=0 -DWATCHDOG_VERSION_MINOR=10 -DWATCHDOG_VERSION_BUILD=1 -I/Users/keimlink/projects/watchdog/.venv/include -I/Users/keimlink/.pyenv/versions/3.8.1/include/python3.8 -c src/watchdog_fsevents.c -o build/temp.macosx-10.11-x86_64-3.8/src/watchdog_fsevents.o -std=c99 -pedantic -Wall -Werror -Wextra -fPIC -Wno-error=unused-command-line-argument -Wno-nullability-completeness
src/watchdog_fsevents.c:190:26: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ((callback_result == ((void*)0)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:190:26: note: remove extraneous parentheses around the comparison to silence this warning
if ((callback_result == ((void*)0)))
~ ^ ~
src/watchdog_fsevents.c:190:26: note: use '=' to turn this equality comparison into an assignment
if ((callback_result == ((void*)0)))
^~
=
src/watchdog_fsevents.c:370:16: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ((value == ((void*)0)))
~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:370:16: note: remove extraneous parentheses around the comparison to silence this warning
if ((value == ((void*)0)))
~ ^ ~
src/watchdog_fsevents.c:370:16: note: use '=' to turn this equality comparison into an assignment
if ((value == ((void*)0)))
^~
=
src/watchdog_fsevents.c:428:16: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ((value == ((void*)0)))
~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:428:16: note: remove extraneous parentheses around the comparison to silence this warning
if ((value == ((void*)0)))
~ ^ ~
src/watchdog_fsevents.c:428:16: note: use '=' to turn this equality comparison into an assignment
if ((value == ((void*)0)))
^~
=
src/watchdog_fsevents.c:495:16: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ((value == ((void*)0))) {
~~~~~~^~~~~~~~~~~~~
src/watchdog_fsevents.c:495:16: note: remove extraneous parentheses around the comparison to silence this warning
if ((value == ((void*)0))) {
~ ^ ~
src/watchdog_fsevents.c:495:16: note: use '=' to turn this equality comparison into an assignment
if ((value == ((void*)0))) {
^~
=
4 errors generated.
error: command 'ccache' failed with exit status 1
----------------------------------------
ERROR: Command errored out with exit status 1: /Users/keimlink/projects/watchdog/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/keimlink/projects/watchdog/setup.py'"'"'; __file__='"'"'/Users/keimlink/projects/watchdog/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.
WARNING: You are using pip version 19.2.3, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.Steps to reproduce:
|
|
I orce-pushed on the same branch. Could you have another try please? Sorry to ask you that :) |
|
@BoboTiG thanks for your work here! I am having the same issue mentioned above, with the exception that I am using pipenv to manage my dependencies, and am using python 3.7.1 on MacOS 10.15.3 (released yesterday, but I had the same issue on 10.15.2). I am able to repro by cloning and building master branch. Unfortunately, I am still encountering the same issue when building the Note: I have another project that also depends on watchdog 0.10.0 and I have no trouble installing and I cannot explain why. |
|
@BoboTiG I tried installing with your fix branch, but still results in the same errors unfortunately. |
|
OK we will finally get that fixed! |
|
I noticed this a while ago but actually ignored since I had a version installed before the upgrade that still works. I tried Update: this is the output https://gist.github.com/erickmendonca/dbeca2d5edb2a45dc01c28436da14294 |
|
Unfortunately same error even with the latest updates on the |
|
OK, I removed |
|
Thanks for your continuous effort, @BoboTiG! I tested f87d1cf and everything is working fine! 👍 Obtaining file:///Users/keimlink/projects/watchdog
Collecting pathtools>=0.1.1 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/e7/7f/470d6fcdf23f9f3518f6b0b76be9df16dcc8630ad409947f8be2eb0ed13a/pathtools-0.1.2.tar.gz
Collecting pyobjc-framework-Cocoa>=4.2.2 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/7f/fa/5b2f6ae289e98471676dde3887b7d78f5166cbd7bd99943506abd76b2bd0/pyobjc_framework_Cocoa-6.1-cp38-cp38-macosx_10_9_x86_64.whl
Collecting pyobjc-framework-FSEvents>=4.2.2 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/1f/2c/18237d753ca6a4f6e09e043941aafd244c047c27dfd544e8dd1a71d800eb/pyobjc_framework_FSEvents-6.1-cp38-cp38-macosx_10_9_x86_64.whl
Collecting PyYAML>=3.10 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/3d/d9/ea9816aea31beeadccd03f1f8b625ecf8f645bd66744484d162d84803ce5/PyYAML-5.3.tar.gz
Collecting argh>=0.24.1 (from watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/06/1c/e667a7126f0b84aaa1c56844337bf0ac12445d1beb9c8a6199a7314944bf/argh-0.26.2-py2.py3-none-any.whl
Collecting pyobjc-core>=6.1 (from pyobjc-framework-Cocoa>=4.2.2->watchdog==0.10.1)
Using cached https://files.pythonhosted.org/packages/73/2c/e90c0bb97a455bfe1ec7f8ad6ddfdd8fe55ece448566487242354a4401f6/pyobjc_core-6.1-cp38-cp38-macosx_10_9_x86_64.whl
Installing collected packages: pathtools, pyobjc-core, pyobjc-framework-Cocoa, pyobjc-framework-FSEvents, PyYAML, argh, watchdog
Running setup.py install for pathtools ... done
Running setup.py install for PyYAML ... done
Running setup.py develop for watchdog
Successfully installed PyYAML-5.3 argh-0.26.2 pathtools-0.1.2 pyobjc-core-6.1 pyobjc-framework-Cocoa-6.1 pyobjc-framework-FSEvents-6.1 watchdogThis is the output of usage: watchmedo [-h] [--version] {tricks-from,tricks,tricks-generate-yaml,generate-tricks-yaml,log,shell-command,auto-restart} ...
positional arguments:
{tricks-from,tricks,tricks-generate-yaml,generate-tricks-yaml,log,shell-command,auto-restart}
tricks-from (tricks)
Subcommand to execute tricks from a tricks configuration file. :param args: Command line argument options.
tricks-generate-yaml (generate-tricks-yaml)
Subcommand to generate Yaml configuration for tricks named on the command line. :param args: Command line argument options.
log Subcommand to log file system events to the console. :param args: Command line argument options.
shell-command Subcommand to execute shell commands in response to file system events. :param args: Command line argument options.
auto-restart Subcommand to start a long-running subprocess and restart it on matched events. :param args: Command line argument options.
optional arguments:
-h, --help show this help message and exit
--version show program's version number and exit
Copyright 2011 Yesudeep Mangalapilly <[email protected]>.
Copyright 2012 Google, Inc.
Licensed under the terms of the Apache license, version 2.0. Please see
LICENSE in the source code for more information. |
|
Ah that is an excellent news, thanks @keimlink ! |
|
@BoboTiG I tested as well and it resolves the issues I was having. Thank you!!! |
|
Strangely it still seems to fail for me. Since it fixed the issue for @thomaspsk on 10.15.3 though, I'm really wondering if the issue is specific to my machine. I'm working around it for now using |
|
I now merged the fix. Could yo post the output @ericve25? |
|
And I think I still need to add the |
|
|
|
I love when it works so smoothly :) |
|
The release 0.10.1 is out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pip install watchdogfails after I upgraded to macOS 10.15.2 with this error:Any suggestions on how to resolve this?
So far I've tried removing and reinstalling both xcode and command line tools which hasn't helped. Not sure what else to try here.
The text was updated successfully, but these errors were encountered: