Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script:contains() doesn't seem to handle script/rocketscript script tags? #2354

Closed
fake-name opened this issue Feb 4, 2017 · 16 comments
Closed

Comments

@fake-name
Copy link

fake-name commented Feb 4, 2017

Describe the issue

I'm trying to block some of the particularly spectacularly obnoxious ads, using the script:contains() command, and it seems to not be working?

One or more specific URLs where the issue occurs

https//www.nepustation.com/
Probably others. This is largely a function of blockadblock.com's functionality.

Steps for anyone to reproduce the issue

I've created the following custom filters:

www.nepustation.com##script:contains(KillAdBlock)
www.nepustation.com##script:contains(kill_adBlock_status)
www.nepustation.com##script:contains(document.write)
www.nepustation.com##script:contains(Place this code snippet near the footer of your page before the close of the /body tag)

I'd expect this to block the blockadblock script, but it doesn't seem to work.
Either I'm misunderstanding how the script:contains() command works (the fact that it doesn't require "" around the script string makes me suspect I'm doing something wrong), or I don't know what's going on.

Your settings

  • Browser/version: Vivaldi 1.6.689.40 (Stable channel) (32-bit)
  • uBlock Origin version: 1.10.4
Your filter lists

Defaults

Your custom filters (if any)

See above.


There's also some fun other bullshit here: The site uses a custom font with reordered codepoints to "protect" it's content from copy+paste (and break screen-readers, reading mode, and basically kill kittens for every refresh too).

@uBlock-user
Copy link
Contributor

Are you on Vivaldi ? If so, inline-script tag filtering will not work. That's a feature only working on Firefox and its derivatives.

@mapx-
Copy link

mapx- commented Feb 4, 2017

however, use
@@||nepustation.com^$generichide

@toshiya44
Copy link

On firefox. Disabling generichide didn't work.

@uBlock-user
Copy link
Contributor

add

nepustation.com##script:inject(bab-defuser.js)
@@||nepustation.com^$elemhide

@toshiya44
Copy link

Above solution didn't work either.
Apparently the site checks to see if http://ajax.cloudflare.com/cdn-cgi/nexp/dok3v=f2befc48d1/cloudflare.min.js is loaded. Allowing it unblocks the site.
What does this Javascript do?

@toshiya44
Copy link

toshiya44 commented Feb 4, 2017

nepustation.com##body:style(visibility: visible !important;)
This works

@mapx-
Copy link

mapx- commented Feb 4, 2017

the generichide (or elemhide) filter is working fine (tested in firefox / chrome + ubo / ABP)

@fake-name
Copy link
Author

Are you on Vivaldi ?

Wow, I fail at reporting.

If so, inline-script tag filtering will not work. That's a feature only working on Firefox and its derivatives.

I fail at reading the documentation as well, apparently. That explains it. Is there a timeline for getting this in non-firefox browsers?

@mapx-
Copy link

mapx- commented Feb 4, 2017

@uBlock-user
Copy link
Contributor

uBlock-user commented Feb 4, 2017

My solution works fine on Chromium, I haven't tested on Firefox, as I don't use Firefox, but it should. Update all your uBlock filters, and uBlock resources.

Is there a timeline for getting this in non-firefox browsers?

Never. Read - whatwg/html#943

@fake-name
Copy link
Author

@uBlock-user - Yeah, reading that thread and feeling raeg at the moment. I love all the "people should use <other thing that's not even specified yet>" responses.

@uBlock-user
Copy link
Contributor

@fake-name FYI, It might get removed from Firefox too - https://bugzilla.mozilla.org/show_bug.cgi?id=1286822

@fake-name
Copy link
Author

fake-name commented Feb 4, 2017

It's fine if they remove it, as long as a replacement is implemented first.

I'd assume they're going to remove it, and then never bother implementing any replacement, though.

@uBlock-user
Copy link
Contributor

uBlock-user commented Feb 4, 2017

There won't be any replacement neither any plans, they're following in the steps of what Google and others decided.

@gorhill
Copy link
Owner

gorhill commented Feb 4, 2017

nepustation.com##script:inject(bab-defuser.js)
nepustation.com##script:inject(abort-on-property-write.js, KillAdBlock)

@gorhill
Copy link
Owner

gorhill commented Feb 4, 2017

Duplicate of #2015.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants