Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Adguard's [-ext-has="..."] syntax => convert to uBO's :if(...) #2624

Closed
gorhill opened this issue May 17, 2017 · 4 comments
Closed

Comments

@gorhill
Copy link
Owner

gorhill commented May 17, 2017

#1930 (comment)

I am considering adding Adguard's English filters to uBO's stock lists, as it takes care of many things not covered by EasyList, so extending compatibility as much as possible is a requirement.

@happysurf
Copy link

happysurf commented May 17, 2017

Actually I use Adguard Spyware filter, Social Filter and Annoyances filter.
These filters are relatively small but very powerful without any problems.
In my opinion are better of > Social > Fanboy's lists and > Privacy >Easy Privacy.
Will be great add also these filters.
Filters: https://kb.adguard.com/en/general/adguard-ad-filters

Why UBO use only in the Adguard English filter a very small number of entries?

Adguard Annoyances Filter​​​​​
6.857 used out of 6.917​​
​​
Adguard Social Media Filter​​
​​​3.796 used out of 3.978​​
​​
Adguard Spyware Filter​​
​​​5.233 used out of 5.280​​
​​
English filter​​
​​​7.223 used out of 79.963​​​

Repository owner locked and limited conversation to collaborators May 17, 2017
@gorhill
Copy link
Owner Author

gorhill commented May 17, 2017

Why UBO use only in the Adguard English filter a very small number of entries?

Read the documentation please: https://github.com/gorhill/uBlock/wiki/Dashboard:-3rd-party-filters.

@gorhill
Copy link
Owner Author

gorhill commented May 20, 2017

Fixed with be9d76f.

@gorhill gorhill closed this as completed May 20, 2017
@gorhill
Copy link
Owner Author

gorhill commented May 20, 2017

The real fix does map Adguard's -ext-has[...] to uBO's :if(...), given that -ext-has is often used with procedural selector contains as part of its argument.

@gorhill gorhill changed the title Support Adguard's [-ext-has="..."] syntax => convert to uBO's :has(...) Support Adguard's [-ext-has="..."] syntax => convert to uBO's :if(...) May 20, 2017
gdh1995 pushed a commit to gdh1995/uBlock that referenced this issue Dec 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants