-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privacy settings are not persisting if firefox not restarted after ublock install #343
Comments
Can you describe how exactly you did this? |
I installed 0.9.8.2, quit Firefox 38, launched Firefox, drag and dropped 0.9.9.0-rc.0 in Firefox, and the privacy checkboxes worked as expected. I don't know how to recreate your issue. From the description, it is as if the core code from 0.9.8.2 was still in effect, while the dashboard code was that of 0.9.9.0, i.e. the core didn't know about these new privacy settings while the dashboard knew about them. |
I installed ublock few week ago from AMO. So, I had ublock 0.9.8.2 installed before installing 0.9.9.0-rc.0. After that, I went to
I was able to reproduce it again, by doing just that. It's reproducible on my system every time.
That's what I thought, which is why I restarted(close all windows then open) Firefox. Also I noticed few things when I repeated above quoted method to reproduce bug.
|
Is it in the menu? Or removed from toolbar and menu? |
When ublock is installed for very first time, ublock icons appear in toolbar. So, I removed this ublock icon from toolbar. I did not place it to hamburger menu either, because I rarely, if ever use functionality given in popup ui. |
Is that same like here: #321? |
I have launched Firefox at least 10 times since creating this issue. None of my settings or filters are reset or lost. It's just that, very first time when I installed latest ublock, privacy setting were unchecked and new features were inaccessible. After I restarted firefox, every thing is working as expected. No problem since then. @MiraziHeket If your settings resets every time then It is different bug. |
So, I updated ublock from 0.9.9.0 to 0.9.9.1, and bug appears to be gone. To be sure, without restarting firefox I checked if new by ublock is autoreloaded on update.
That's how I concluded that bug is fixed. I do not wish to waste developer time on this bug, as it was not a major bug and is solved. |
I installed ublock 0.9.9.0-rc.0 over ublock 0.9.8.2 (installed via AMO) on Firefox 38.0.5.
Both privacy settings (i.e. disable prefetching and hyperlink auditing) were unchecked.
So, I checked both settings and closed dashboard.
Opened dashboard again after few minutes. Both privacy setting were unchecked. So, I checked them again and closed the dashboard. Opened dashboard again, both privacy settings were still unchecked.
Tried above with other settings like 'i am advanced user', 'color-blind friendly'
etc and these settings were persisting as they should.
I restarted Firefox and problem vanished. Now privacy settings are persisting like other settings.
The text was updated successfully, but these errors were encountered: