Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup identified as "doc" request when opened by iframe #452

Closed
anewuser opened this issue Jul 6, 2015 · 1 comment
Closed

Popup identified as "doc" request when opened by iframe #452

anewuser opened this issue Jul 6, 2015 · 1 comment

Comments

@anewuser
Copy link
Contributor

anewuser commented Jul 6, 2015

I've set these dynamic rules to block popups from this page:

no-popups: geektv.me true
no-popups: youwatch.org true

The popup is blocked if I open the iframe URL directly and click on the player: http://youwatch.org/embed-xlmfhm97etcg-850x450.html

popup blocked

However, if I click on the same player on the Geektv page, the ad popup isn't blocked because it's seen as a legit new document request: http://geektv.me/watch/14861

popup identified as doc

These two sites both have other ads, which I've blocked with other rules and filters. This issue is only about popups called by this function:

function lads() {
    window.open('http://ds1.vids.ma/KeclfbD2', 'velro', 'location=no,fullscreen=yes'); 
}

The popup URL may be different when you test it because they keep changing their ad hosts.

Firefox 40 (Beta) for Windows
uBlock Origin 0.9.9.3

@gorhill
Copy link
Owner

gorhill commented Jul 7, 2015

I can reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants