Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 #138

Open
nimbit-software opened this issue Dec 26, 2024 · 2 comments
Open

React 19 #138

nimbit-software opened this issue Dec 26, 2024 · 2 comments

Comments

@nimbit-software
Copy link
Contributor

nimbit-software commented Dec 26, 2024

React 19 introduces some breaking changes with ref (and a few other things).

This seems to effect the current project. I would be happy to help get that resolved.

I realize that react 19 is still in RC but nextjs 15 requires it and i think the issues that currently exist

hook.js:608 Accessing element.ref was removed in React 19. ref is now a regular prop. It will be removed from the JSX Element type in a future release. Error Component Stack
    at div (<anonymous>)
    at g (<anonymous>)
    at g (<anonymous>)
    at svg (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
    at div (<anonymous>)
render.js:51 Uncaught TypeError: reactRender is not a function
    at legacyRender (render.js:51:3)
    at render (render.js:65:3)
    at showWaveEffect (WaveEffect.js:139:68)
    at useWave.useEvent[showWave] [as current] (useWave.js:34:80)
    at eval (useEvent.js:16:114)
    at eval (useWave.js:48:13)
    at callRef (raf.js:34:7)
    at eval (raf.js:38:9)

just wanted to makre sure there is no ongoing work on that before i start trying to fingure out what is causing the problem.

The second error seems related the the antd wave and seems to be a know limitation

https://ant.design/docs/react/v5-for-19

@ivanmiletic
Copy link
Contributor

We would be happy if you would like to solve it. There is no ongoing big work on JDM Editor

@nimbit-software
Copy link
Contributor Author

Great ill take a look at it and see if i can put something together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants