Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Uncovered Branches when generating ngrx effects #818

Open
phillipzada opened this issue Jun 21, 2017 · 1 comment
Open

Uncovered Branches when generating ngrx effects #818

phillipzada opened this issue Jun 21, 2017 · 1 comment

Comments

@phillipzada
Copy link

phillipzada commented Jun 21, 2017

Hi all,

Been racking my brain for days on this one, can't seem to figure what branches are being missed/marked uncovered from this code

2017-06-21_11-39-41

Is there any suggestions on a fix, or is there a possible way to find out what branches Istanbul thinks I'm missing?

using angular-cli test, karma, karma-coverage-istanbul-reporter if that helps.

I think it has something to do with Observable as the ActionExtension class extends Observable, and its constructor was previously flagged uncovered code too when a type was set

export class ActionExtensions extends Observable<Action> {
 constructor( @Inject(Dispatcher) actionsSubject: any /*Observable<Action> Replaced with any due to Code Coverage Issue*/) {
@phillipzada phillipzada changed the title Unknown Branches when generating ngrx effects Uncovered Branches when generating ngrx effects Jun 21, 2017
@phillipzada
Copy link
Author

It must be related to angular/angular-cli#5526

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant