Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid value for varchar field when running ght-restore-pg #80

Open
larsborn opened this issue Nov 14, 2018 · 1 comment
Open

Invalid value for varchar field when running ght-restore-pg #80

larsborn opened this issue Nov 14, 2018 · 1 comment

Comments

@larsborn
Copy link
Contributor

Executing the ght-restore-pg on the data from 2018-09-01 gives the following error:

ERROR:  value too long for type character varying(356)
CONTEXT:  COPY commit_comments, line 2315625, column body: "@@ -0,0 +1,462 @@

this is due to the fact that the field body in commit_comments is specified as varying(356) in pg_schema.sql. I suggest changing the type to text.

To my knowledge this doesn't have any negative effect on space requirements and should even increase import performance since length of the data doesn't need to be checked. Should I submit a PR?

@gousiosg
Copy link
Owner

Yes, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants