New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DayPickerInput doesn't call dayPickerProps.onMonthChange #603

Closed

ah-adarlow opened this issue Jan 8, 2018 · 1 comment · Fixed by #604

Labels

good first issue

Contributor

ah-adarlow commented Jan 8, 2018 •

edited by gpbl

Loading

DayPickerInput overrides the onMonthChange handler passed in through dayPickerProps and doesn't call it when the month changes.

See DayPickerInput.js line 446.

https://codesandbox.io/s/km00lz2vq3

gpbl added bug good first issue labels

Owner

gpbl commented Jan 8, 2018

Confirmed! Someone may want to fix it :)

this line should become:

- onMonthChange={month => this.setState({ month })}
+ onMonthChange={this.handleMonthChange}

handleMonthChange should setState({month}) and use as callback props.dayPickerProps.onMonthChange –if it exists– with the same args
must add a test for handleMonthChange calling onMonthChange

ah-adarlow mentioned this issue

Fixed DayPickerInput not calling dayPickerProps.onMonthChange #604

Merged

gpbl closed this as completed in #604

snyk-bot mentioned this issue

[Snyk] Upgrade css-loader from 0.19.0 to 0.28.11 rangle/react-day-picker#2

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment