-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: options.id
can be set to Client ID
#98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
commented
May 2, 2024
gr2m
commented
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid friction for downstream users, I think would make sense to implement the appId
type of the result to be inferred by the id
type passed to the function
Update: done ✅
gr2m
changed the title
Update 'id' argument type to accept number or string
feat: May 2, 2024
options.id
can be set to Client ID
🎉 This PR is included in version 2.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling and documentation of the
id
argument to accept both a number (App ID) or a string (Client ID), enhancing flexibility in accordance with GitHub's recommendations.index.d.ts
andinternals.d.ts
to allow theid
parameter andappId
result to be either a number or a string.README.md
to clarify thatoptions.id
can be set to either the App ID or Client ID, and recommends using the Client ID forjackfan.us.kg
and GHES 3.14+. The resultingappId
can also be a string accordingly.index.test-d.ts
andtest/node.test.js
to verify functionality whenid
is set to a string.For more details, open the Copilot Workspace session.