Unreachable code warning (C4702) triggered when injecting service dependency in MSVC

[wopss]

Describe the bug
When attempting to inject a service dependency into another service within a C++ project using MSVC compiler, the compiler generates a warning C4702: unreachable code during compilation. This warning occurs specifically in virtual_injected class.

kangaru/include/kangaru/detail/injected.hpp

Line 59 in 329989a

_service{storage.service}, _forward{storage.forward} {}

To Reproduce

1. Create CMakeLists.txt with the following content:

cmake_minimum_required(VERSION 3.21)

include(FetchContent)

project(
  kangaru-c4702-unreachable-code
  LANGUAGES CXX
)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CONFIGURATION_TYPES "Release")

option(KANGARU_REVERSE_DESTRUCTION "" ON)

FetchContent_Declare(
  kangaru
  GIT_REPOSITORY https://github.com/gracicot/kangaru.git
  GIT_TAG        329989aa57210fb9c883ccabc1db666f6b70c34d
)
FetchContent_MakeAvailable(kangaru)

add_compile_options(/W4 /WX)

add_executable(${PROJECT_NAME} Main.cpp)
target_link_libraries(${PROJECT_NAME} PRIVATE kangaru::kangaru)

2. Create the Main.cpp file with the following content:

#include <kangaru/kangaru.hpp>

class Fuel
{
public:
    Fuel() = default;
    virtual ~Fuel() = default;
};

struct FuelService : kgr::abstract_service<Fuel>
{
};

class Car
{
public:
    Car(const Fuel& fuel)
        : m_fuel{fuel}
    {
    }

    virtual ~Car() = default;

private:
    const Fuel& m_fuel;
};

class Toyota : public Car
{
public:
    Toyota(const Fuel& fuel) // This line cause the warning.
        : Car{fuel}
    {
    }

    ~Toyota() final = default;
};

struct ToyotaService
    : kgr::single_service<Toyota, kgr::dependency<FuelService>>
{
};

int main()
{
    kgr::container m_services;
    m_services.emplace<ToyotaService>();
    return 0;
}

3. Compile it in Release.

Expected behavior
The code should compile without triggering any warnings related to unreachable code (warning C4702).

Desktop (please complete the following information):

• OS: Windows
• Compiler: MSVC
• Version: 19.38.33135

Additional context
I tried to figure out if the problem is with kangaru or MSVC, but couldn't recreate it with a similar class as virtual_injected. I assume it might be because of the optimization in Release.

It would be great if you could have a look at it to determine if this is really from kangaru or MSVC, or between the chair and the keyboard.

[gracicot]

Thank you for the report, I'll take a look!

[gracicot]

After looking at it, I can say that I'm almost certain this is a false positive. I would report this to the MSVC team. Those function does not throw and does not use control flow. I cannot see how those could have unreachable code.

I also noticed injected from injected.hpp also show this issue there:

kangaru/include/kangaru/detail/injected.hpp

Line 27 in f66a804

_service{std::forward<Args>(args)...} {}

The workaround would be to compile with kangaru as a system header (I don't think MSVC supports this) or to compile without /WX or with /W3 instead of /W4.

[wopss]

Thank you for investigating! I'll go ahead report it to the MSVC team.

[wopss]

I have reported the issue on Developer Community. If you would like to follow it, here is the link: https://developercommunity.visualstudio.com/t/Unreachable-code-warning-C4702-trigger/10582835

Since this is a false positive, feel free to close this issue.

[gracicot]

Thanks for the link! I'll keep this issue around until we get a response from microsoft's MSVC team.

[gracicot]

I will fix it by adding pragma warning, as the msvc team don't seem keen on fixing it on their side