Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Refactor components #3268

Closed
3 tasks done
pngwn opened this issue Feb 21, 2023 · 2 comments
Closed
3 tasks done

[frontend] Refactor components #3268

pngwn opened this issue Feb 21, 2023 · 2 comments
Assignees
Labels
refactor Involves refactoring existing code svelte Frontend-related issue (JS)

Comments

@pngwn
Copy link
Member

pngwn commented Feb 21, 2023

Components in the frontend are a bit confusing right now which makes component loading + adding new components tricky:

  • we have two of everything and they are inconsistent.
  • some contain the block wrapper, some don't.
  • some have their own statustracker/ loader, some don't.
  • probably more
  • component loading requires quite a bit of work
  • props/event APIs are inconsistent

needs addressing.

Has implications for custom components #1432

The work

Going to break this into a few pieces:

@pngwn pngwn self-assigned this Feb 21, 2023
@pngwn pngwn added refactor Involves refactoring existing code svelte Frontend-related issue (JS) labels Feb 21, 2023
@pngwn pngwn changed the title Refactor components [frontend] Refactor components Feb 21, 2023
@pngwn
Copy link
Member Author

pngwn commented Mar 2, 2023

This is now a tracking issue, I've split the work up.

@abidlabs
Copy link
Member

All the items are done here I believe so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Involves refactoring existing code svelte Frontend-related issue (JS)
Projects
None yet
Development

No branches or pull requests

2 participants