Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of loki.source.file #2345

Open
wildum opened this issue Jan 7, 2025 · 1 comment
Open

Rework of loki.source.file #2345

wildum opened this issue Jan 7, 2025 · 1 comment

Comments

@wildum
Copy link
Contributor

wildum commented Jan 7, 2025

The current implementation of the loki.source.file has some problems:

I suggest reworking this component to use the runner pkg (like the loki.source.docker component) and adding a mechanism for the runners to periodically retry reading the file that they were assigned.

To improve it further, we could use a pool of workers to reduce the number of goroutines

@dehaansa
Copy link
Contributor

Just linking issues: #2292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants