Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison: Don't show redundant attributes when "Full Traces" is selected #240

Open
joe-elliott opened this issue Sep 23, 2024 · 0 comments

Comments

@joe-elliott
Copy link
Member

When "full traces" is selected the rootName and name attributes should always be the same. Similarly the rootServiceName and resource.service.name should always be the same. This is because when "Full Traces" is selected we are using a filter to always select the root span.

Image

Image

My .02: Drop "rootName" and "rootServiceName" as I think the others are more clear in this situation. Note that we are looking to change these strings so the code should handle both the old and new values.

@mdisibio, Do you think there's any good way to just not scan/return this data tempo side? or should we just filter them app side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant