-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudwatch: Add back support for old Log Group picker #73524
Cloudwatch: Add back support for old Log Group picker #73524
Conversation
logGroupLimit = intLimit | ||
} | ||
|
||
var response *cloudwatchlogs.DescribeLogGroupsOutput = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason this is a var
on this line instead of it being on line 310?
response, err := logsClient.DescribeLogGroups(input)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason I can think of! I just copy and 🍝 from what we used to have but I like the suggestion! Changing now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I assume you tried it with a CloudWatch query that returns data (turns out I don't have one locally)
b0d7c2a
to
de4ee7f
Compare
Cloudwatch: Add back support for old Log Group picker behind feature toggle. Fixes issue for aws gov cloud users
Cloudwatch: Add back support for old Log Group picker behind feature toggle. Fixes issue for aws gov cloud users
* Cloudwatch: Add back support for old Log Group picker (#73524)
What is this feature?
When we Added Cross Account Observability to Cloudwatch Logs, we switched to a new log group picker.
This log group picker lets users select Log Groups across multiple accounts if available, and rather than save them by Log Group Name, we saved them by ARN, because Log Group Names do not have to be unique across aws accounts.
After some testing, we decided it seemed to be working well for users using Cross Account Observability and users who were not so we switched all users to the new Log Group Picker.
Unfortunately we learned after doing so that the aws api to query across log groups using log group arns is not supported in Gov Cloud just yet, and may not for sometime. This PR brings back the old Log Group Picker. Most users will continue to see the new Log Group Picker, however if users would like to revert to the old one, they now can by setting a feature flag in their custom.ini (or by making a support request if they are in Grafana Cloud)
Why do we need this feature?
To let AWS Gov Cloud upgrade to more recent versions of Grafana while still using Cloudwatch Logs.
Who is this feature for?
AWS Gov Cloud users
Which issue(s) does this PR fix?:
Fixes #71982
Special notes for your reviewer:
Please check that: