Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade Go to 1.20.10 #76355

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Chore: Upgrade Go to 1.20.10 #76355

merged 2 commits into from
Oct 11, 2023

Conversation

zerok
Copy link
Contributor

@zerok zerok commented Oct 11, 2023

Note that this is not a backport from main as main currently looks totally different and so we take v10.1.x as starting point for the rest of the backport

@zerok zerok added add to changelog backport v9.4.x Mark PR for automatic backport to v9.4.x backport v9.5.x Bot will automatically open backport PR backport v10.0.x labels Oct 11, 2023
@zerok zerok requested review from a team and DanCech as code owners October 11, 2023 13:08
@zerok zerok requested review from a team, rwwiv, JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team October 11, 2023 13:08
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.1.x milestone Oct 11, 2023
@zerok zerok added the product-approved Pull requests that are approved by product/managers and are allowed to be backported label Oct 11, 2023
@zerok zerok enabled auto-merge (squash) October 11, 2023 13:18
@zerok zerok disabled auto-merge October 11, 2023 13:19
@zerok
Copy link
Contributor Author

zerok commented Oct 11, 2023

Ah forgot to regenerate drone ...

@grafana-pr-automation grafana-pr-automation bot added the type/ci Tasks related to Continuous Integration workflow label Oct 11, 2023
@zerok zerok enabled auto-merge (squash) October 11, 2023 13:22
kminehart
kminehart approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@kminehart kminehart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't affect the release artifacts though. The only way to do that is change the default Go version in grafana-build or pass the --go-version argument when calling the "package" command

@zerok
Copy link
Contributor Author

zerok commented Oct 11, 2023

This won't affect the release artifacts though. The only way to do that is change the default Go version in grafana-build or pass the --go-version argument when calling the "package" command

Yes, that's also incoming. Just doing too much in parallel right now :)

@zerok zerok merged commit 4287686 into v10.1.x Oct 11, 2023
7 checks passed
@zerok zerok deleted the zerok/go-1.20.10-for-v10.1.x branch October 11, 2023 13:35
@grafana-delivery-bot

This comment was marked as resolved.

Sign in to view
@grafana-delivery-bot grafana-delivery-bot bot added the backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. label Oct 11, 2023
@grafana-delivery-bot

This comment was marked as resolved.

Sign in to view
@grafana-delivery-bot

This comment was marked as resolved.

Sign in to view
zerok added a commit that referenced this pull request Oct 11, 2023
@zerok
Chore: Upgrade Go to 1.20.10 (#76355)
c6885e1 
* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
@zerok zerok mentioned this pull request Oct 11, 2023
Merged
zerok added a commit that referenced this pull request Oct 11, 2023
@zerok
Chore: Upgrade Go to 1.20.10 (#76355)
fe99dbb 
* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
@zerok zerok mentioned this pull request Oct 11, 2023
Merged
zerok added a commit that referenced this pull request Oct 11, 2023
@zerok
Chore: Upgrade Go to 1.20.10 (#76355)
7a2a116 
* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
@zerok zerok mentioned this pull request Oct 11, 2023
Merged
@grafana grafana deleted a comment from grafana-delivery-bot bot Oct 11, 2023
@grafana grafana deleted a comment from grafana-delivery-bot bot Oct 11, 2023
zerok added a commit that referenced this pull request Oct 11, 2023
@zerok
[v9.5.x] Chore: Upgrade Go to 1.20.10 (#76367)
79b8343 
Chore: Upgrade Go to 1.20.10 (#76355)

* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
@grafana grafana deleted a comment from grafana-delivery-bot bot Oct 11, 2023
zerok added a commit that referenced this pull request Oct 11, 2023
@zerok
[v10.0.x] Chore: Upgrade Go to 1.20.10 (#76365)
6448506 
Chore: Upgrade Go to 1.20.10 (#76355)

* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
zerok added a commit that referenced this pull request Oct 11, 2023
@zerok
[v9.4.x] Chore: Upgrade Go to 1.20.10 (#76370)
10e4fb4 
Chore: Upgrade Go to 1.20.10 (#76355)

* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@zerok
[v9.4.x] Chore: Upgrade Go to 1.20.10 (#76370)
d24c8aa 
Chore: Upgrade Go to 1.20.10 (#76355)

* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@zerok
[v9.5.x] Chore: Upgrade Go to 1.20.10 (#76367)
802385e 
Chore: Upgrade Go to 1.20.10 (#76355)

* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@zerok
[v10.0.x] Chore: Upgrade Go to 1.20.10 (#76365)
439bbb4 
Chore: Upgrade Go to 1.20.10 (#76355)

* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml

(cherry picked from commit 4287686)
grafana-delivery-bot bot pushed a commit that referenced this pull request Oct 12, 2023
@zerok
Chore: Upgrade Go to 1.20.10 (#76355)
849c612 
* [v10.1.x] Chore: Upgrade Go to 1.20.10

* Rebuild .drone.yml
@zerok zerok modified the milestones: 10.1.x, 10.1.5 Oct 12, 2023
@dnhn dnhn mentioned this pull request Oct 12, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsotirakis dsotirakis dsotirakis approved these changes

@kminehart kminehart kminehart approved these changes

@DanCech DanCech Awaiting requested review from DanCech DanCech is a code owner

@rwwiv rwwiv Awaiting requested review from rwwiv

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT

@yuri-tceretian yuri-tceretian Awaiting requested review from yuri-tceretian

@grobinson-grafana grobinson-grafana Awaiting requested review from grobinson-grafana

Assignees
No one assigned
Labels
add to changelog backport v9.4.x Mark PR for automatic backport to v9.4.x backport v9.5.x Bot will automatically open backport PR backport v10.0.x backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. product-approved Pull requests that are approved by product/managers and are allowed to be backported type/build-packaging type/ci Tasks related to Continuous Integration workflow
Projects
None yet
Milestone
10.1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@zerok @kminehart @dsotirakis