Logs Panel: Column selection for experimental table visualization in explore #76983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hooking up hardcoded panel state to explore url and syncing
… reflected in explore url, and initial state from url is populating
…normalizing values, and more
…logs/table-viz-explore-poc
…logs/table-viz-explore-poc
…e with fewer or more labels would render additional unwanted columns before getting cleaned up on the next render. Also documenting and cleaning up
* Sync panel state with explore URL state
…-state' of https://github.com/grafana/grafana into gtk-grafana/features/logs/table-viz-explore-poc__no-url-state
…select results in call to updatePanelState
gtk-grafana
added
add to changelog
and removed
no-changelog
gtk-grafana
changed the title
…logs/table-viz-explore__url-sync
…logs/table-viz-explore__url-sync
* Sync explore URL state with logs panel state in explore
gtk-grafana
requested review from
Clarity-89,
eledobleefe and
leventebalogh
and removed request for
a team
Rudderstack events
gtk-grafana
deleted the
gtk-grafana/features/logs/table-viz-explore__url-sync
branch
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Experimental
New UI for selecting columns in table visualization (under
logsExploreTableVisualisationfeature flag) introduced in #71120.Who is this feature for?
Internal users and early adopters that use logs in explore.
Special notes for your reviewer:
Took the work @svennergr started and added a HoC component (
LogsTableWrap) to receive the dataframe and create a filtered copy of that data frame based on the current state of the filters, which is passed into the dataframeTablecomponent. The filtering and extracting of fields (columns) is handled by the organizeFields and extractFields transformations.Tested with cloudwatch, loki, and elastic
Please check that: