Dashboards: Fix dashboard listing when user can't list any folders #77983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IevaVasiljeva
requested review from
ashharrison90
and removed request for
a team
joshhunt
approved these changes
Nov 10, 2023
This was referenced Nov 10, 2023
3 tasks
IevaVasiljeva
added a commit
that referenced
this pull request
Nov 10, 2023
…folders (#77988) Dashboards: Fix dashboard listing when user can't list any folders (#77983) * return empty list of folder if the user doesn't have the permissions to view folders * fix the empty folder list initialisation (cherry picked from commit 6097ff2) Co-authored-by: Ieva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Allow a user to correctly list dashboards when no folders exist in the organization or when the user isn't allow to list any folders in this organization.
Before the change:
Screenshare.-.2023-11-10.10_46_27.AM.mp4
After the change:
Screenshare.-.2023-11-10.10_45_09.AM.mp4
Why do we need this feature?
Currently dashboard and folder listing page is broken if the user isn't allowed to list any folders.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Related to #77803 (comment)
Fixes #77985
Special notes for your reviewer:
Please check that: