Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables: Add support for aliasIDs to datasource variables (Fixes issue with Postgres datasource variables) #78170

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Variables: Add support for aliasIDs to datasource variables (Fixes issue with Postgres datasource variables) #78170

merged 2 commits into from
Nov 15, 2023

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Nov 15, 2023

There are still a few places where aliasIDs are not taken into account. I expect some more in community/customer plugins.

Scenes DataSourceVariable did not have this problem as it's using DataSourceSrv.getList with a pluginId filter.

@torkelo torkelo requested review from a team as code owners November 15, 2023 08:55
@torkelo torkelo requested review from dprokop, kaydelaney, sunker, Clarity-89, ashharrison90 and andresmgot and removed request for a team, sunker, Clarity-89 and ashharrison90 November 15, 2023 08:55
@torkelo torkelo added this to the 10.3.x milestone Nov 15, 2023
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

Hello @torkelo!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

dprokop
dprokop reviewed Nov 15, 2023
View reviewed changes
public/app/features/dashboard-scene/utils/getNextPanelId.ts Outdated

import { getPanelIdForVizPanel } from './utils';

export class NextPanelIdGenerator {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torkelo - Not related to this PR I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprokop oops, no that was a test from yesterday :)

@torkelo torkelo changed the title Variables: Add support for aliasIDs to datasource variables Variables: Add support for aliasIDs to datasource variables (Fixes issue with Postgres datasource variables) Nov 15, 2023
dprokop
dprokop approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andresmgot
andresmgot approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this fixes the issue, thanks!

@torkelo torkelo merged commit f7e5689 into main Nov 15, 2023
@torkelo torkelo deleted the fix-datasource-variable branch November 15, 2023 10:18
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Nov 15, 2023
Closed
grafana-delivery-bot bot pushed a commit that referenced this pull request Nov 15, 2023
@torkelo @grafana-delivery-bot
Variables: Add support for aliasIDs to datasource variables (Fixes is…
b998105 
…sue with Postgres datasource variables) (#78170)

* Variables: Add support for aliasIDs to datasource variables

* remove file

(cherry picked from commit f7e5689)
@andresmgot andresmgot mentioned this pull request Nov 16, 2023
Closed
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprokop dprokop dprokop approved these changes

@andresmgot andresmgot andresmgot approved these changes

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/dashboard/templating area/frontend backport v10.2.x type/bug
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@torkelo @dprokop @andresmgot @aangelisc