AuthN: Support reloading SSO config after the sso settings have changed #80734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…svc-reload-support
mgyongyosi
changed the title
mgyongyosi
force-pushed
the
mgyongyosi/sso/authn-svc-reload-support
branch
from
f07ca07 to
14d3b34
Compare
mgyongyosi
force-pushed
the
mgyongyosi/sso/authn-svc-reload-support
branch
from
14d3b34 to
a7d61b5
Compare
mgyongyosi
added
the
no-changelog
mgyongyosi
changed the title
mgyongyosi
added
add to changelog
and removed
no-changelog
kalleep
reviewed
Jan 19, 2024
mgyongyosi
force-pushed
the
mgyongyosi/sso/authn-svc-reload-support
branch
from
aa792c0 to
78c24d8
Compare
mgyongyosi
force-pushed
the
mgyongyosi/sso/authn-svc-reload-support
branch
from
78c24d8 to
95728a9
Compare
kalleep
approved these changes
Jan 22, 2024
| func (s *SocialGenericOAuth) Reload(ctx context.Context, settings ssoModels.SSOSettings) error { | ||
| newInfo, err := CreateOAuthInfoFromKeyValues(settings.Settings) | ||
| if err != nil { | ||
| return fmt.Errorf("SSO settings map cannot be converted to OAuthInfo: %v", err) |
There was a problem hiding this comment.
We repeat this error in all providers, extract it?
dmihai
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds the ability to reload OAuth provider configuration when SSO settings feature is enabled. Besides, it changes how the AuthN service handles OAuth clients (all of the clients will be registered on startup).
Why do we need this feature?
To update Grafana's OAuth client to support reloading configuration without restarting Grafana.
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: