Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.0.x] DashboardScene: Fixes react panels with old angular options #86411

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[v11.0.x] DashboardScene: Fixes react panels with old angular options #86411

merged 1 commit into from
Apr 17, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 989e7c2 from #86256

Fixes #77260

Problem

  • Angular panels that change from angular to react (Without any change to panel plugin id), only rely on using the panel migration handler to transfer old angular options to the new options structure. In scenes we only support this when the plugin id changes as well (as then we call the onPanelTypeChanged migration handler). But when it's the same plugin Id we just call the normal "version" migration handler and to this handler we do not pass the old root level properties.

Tested with an old version of the home gev dashboard (has old dashlist panels with panel model root level options):
https://github.com/grafana/grafana/blob/v7.5.15/devenv/dev-dashboards/home.json

@torkelo @grafana-delivery-bot
DashboardScene: Fixes react panels with old angular options (#86256)
61c8476 
* DashboardScene: Fixes react panels with old angular options

* Update

(cherry picked from commit 989e7c2)
@grafana-delivery-bot grafana-delivery-bot bot requested review from grafanabot and a team as code owners April 17, 2024 06:06
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Apr 17, 2024
@grafana-delivery-bot grafana-delivery-bot bot requested review from bfmatei and mdvictor and removed request for a team April 17, 2024 06:06
@grafana-delivery-bot grafana-delivery-bot bot requested a review from torkelo April 17, 2024 06:06
@torkelo torkelo enabled auto-merge (squash) April 17, 2024 06:07
@torkelo torkelo merged commit 9b33f96 into v11.0.x Apr 17, 2024
21 checks passed
@torkelo torkelo deleted the backport-86256-to-v11.0.x branch April 17, 2024 06:23
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@bfmatei bfmatei Awaiting requested review from bfmatei bfmatei is a code owner automatically assigned from grafana/dashboards-squad

@mdvictor mdvictor Awaiting requested review from mdvictor mdvictor is a code owner automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR type/bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@torkelo @fabrizio-grafana