Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no new line after password prompt for login command #1703

Closed
mstoykov opened this issue Nov 2, 2020 · 2 comments · Fixed by #1749
Closed

There is no new line after password prompt for login command #1703

mstoykov opened this issue Nov 2, 2020 · 2 comments · Fixed by #1749
Labels
bug good first issue lower prio ux
Milestone
v0.30.0

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Nov 2, 2020

The screenshot shows it very clearly :).
image

I expect that the reading of the password just swallows the newline as well so it doesn't get printed ?
@mstoykov mstoykov added this to the v0.30.0 milestone Nov 2, 2020
@paroar
Copy link
Contributor

paroar commented Nov 27, 2020

I'd like to work on this one ✋

@na--
Copy link
Member

na-- commented Nov 27, 2020

Sure, @paroar, thanks!

This was referenced Nov 28, 2020
Closed
Merged
imiric referenced this issue Dec 7, 2020
@paroar
Fix break line after password input (loadimpact#1703) (#1749)
420dd41 
* Fix break line after password input (loadimpact#1703)

* PasswordField type assertion

* Form PasswordField type assertion
salem84 referenced this issue in salem84/k6 Feb 3, 2021
@paroar @salem84
Fix break line after password input (loadimpact#1703) (grafana#1749)
bec53d6 
* Fix break line after password input (loadimpact#1703)

* PasswordField type assertion

* Form PasswordField type assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue lower prio ux
Projects
None yet
Milestone
v0.30.0
Development

Successfully merging a pull request may close this issue.

Fix break line after password input (loadimpact#1703)
Fix break line after password input (#1703)
3 participants
@mstoykov @na-- @paroar