docker: Do not pin the ca-certs pkg #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## release/v0.44.1 #3060 +/- ##
==================================================
Coverage ? 77.01%
==================================================
Files ? 228
Lines ? 17066
Branches ? 0
==================================================
Hits ? 13144
Misses ? 3079
Partials ? 843
Flags with carried forward coverage won't be shown. Click here to find out more. |
olegbespalov
previously approved these changes
May 8, 2023
imiric
reviewed
May 8, 2023
codebien
force-pushed
the
fix-docker-ca-certs
branch
from
e874270 to
df417af
Compare
olegbespalov
approved these changes
May 8, 2023
imiric
approved these changes
May 8, 2023
Hadolint advises to pin a version, but in this specific case isn't very useful because: - We always want the latest version for the ca-certificates package - It has a date-based versioning so we couldn't use the common `=~` selector for patch updates. It mostly breaks every time the Alpine repository releases a new version because they don't keep the previous one.
codebien
force-pushed
the
fix-docker-ca-certs
branch
from
df417af to
8c3dd41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hadolint advises to pin a version, but in this specific case isn't very useful because:
=~selector for patch updates. It mostly breaks every time the Alpine repository releases a new version because they don't keep the previous one.See also: hadolint/hadolint#464 (comment)