Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugins in Promtail's pipeline #1055

Closed
rfratto opened this issue Sep 25, 2019 · 7 comments
Closed

Support plugins in Promtail's pipeline #1055

rfratto opened this issue Sep 25, 2019 · 7 comments
Labels
component/agent keepalive An issue or PR that will be kept alive and never marked as stale. type/feature Something new we should do

Comments

@rfratto
Copy link
Member

rfratto commented Sep 25, 2019

It would be great if Promtail supported third-party plugins as a stage in a pipeline. We could do this using Hashicorp's go-plugin library, which would be ideal for cross-language support.

@sh0rez
Copy link
Member

sh0rez commented Sep 26, 2019

While I personally like the idea of go-plugin more, we still might want to consider embedded scripting languages:

@sh0rez sh0rez added component/agent type/feature Something new we should do labels Sep 26, 2019
@pracucci
Copy link
Contributor

pracucci commented Oct 8, 2019

From my perspective, plugins and scripting would cover different use cases. Plugins may be used to add pipeline stages without any technical limitation, while scripting would be limited to the scripting language capabilities and its functions library. In this scenario, an embedded scripting language may be eventually implemented as a plugin itself.

For this reason, I would suggest to keep this discussion focused on a plugins system.

@stale
Copy link

stale bot commented Nov 7, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Nov 7, 2019
@pracucci pracucci added the keepalive An issue or PR that will be kept alive and never marked as stale. label Nov 7, 2019
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Nov 7, 2019
@roidelapluie
Copy link
Contributor

What about we promote fluentbit instead? It works well for us and has plugins.

@rfratto
Copy link
Member Author

rfratto commented Nov 19, 2019

I definitely don't want to discourage fluentbit, but I personally see fluentbit as ideal only if users are already using it. If a user is exploring Loki and wants plugins, it might be discouraging to see that they have to set up a second piece of software in their infrastructure to enable that.

Just my two cents, other core maintainers might view it differently.
/cc @slim-bean @cyriltovena

@cstyan
Copy link
Contributor

cstyan commented Nov 8, 2023

@rfratto I think we can close this?

@rfratto
Copy link
Member Author

rfratto commented Nov 8, 2023

Yeah sounds like it's unlikely to happen in Promtail, but Grafana Agent had been discussing a plugin model instead. Closing.

@rfratto rfratto closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/agent keepalive An issue or PR that will be kept alive and never marked as stale. type/feature Something new we should do
Projects
None yet
Development

No branches or pull requests

5 participants