Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.4.0: x_build_info isn't emitting version anymore. #1208

Closed
Robert-Stam opened this issue Oct 29, 2019 · 5 comments
Closed

v0.4.0: x_build_info isn't emitting version anymore. #1208

Robert-Stam opened this issue Oct 29, 2019 · 5 comments
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@Robert-Stam
Copy link

Describe the bug
loki_build_info and promtail_build_info isn't emitting version anymore.
This was emitted in v0.1.0-0.3.0

To Reproduce
Steps to reproduce the behavior:

  1. Started Loki & Promtail 0.4.0
  2. Scrape both components with Prometheus
  3. Retrieve the loki_build_info and promtail_build_info metrics
  4. Inspect that the 'version' label is missing.

Expected behavior
The 'version' label with value '0.4.0'

Environment:

  • Infrastructure: Kubernetes Google gke (k8s v 1.14.6)
  • Deployment tool: Yaml
@daixiang0 daixiang0 mentioned this issue Nov 4, 2019
Closed
@stale
Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Nov 28, 2019
@Robert-Stam
Copy link
Author

I checked with v1.0.0, however it's still broken.

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Nov 28, 2019
@cyriltovena
Copy link
Contributor

Someone is working on this I believe

@cyriltovena cyriltovena added the keepalive An issue or PR that will be kept alive and never marked as stale. label Nov 28, 2019
@pstibrany
Copy link
Member

Someone is working on this I believe

It's fixed in PR #1095.

@frittentheke frittentheke mentioned this issue Oct 29, 2021
Closed
@frittentheke
Copy link
Contributor

@cyriltovena I just ran into this same issue with version 2.3.0 again - see #4587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version info missing daixiang0/loki
4 participants
@pstibrany @cyriltovena @frittentheke @Robert-Stam