Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Fix strategy logger and add task test #14857

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

This PR

  • Fixes the strategy logger
  • Adds a test to convert to/from a prototask

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts requested a review from a team as a code owner November 11, 2024 10:29
@salvacorts salvacorts force-pushed the salvacorts/minor-fixes-planner branch from 1febc69 to 4cfaf21 Compare November 11, 2024 10:30
@salvacorts salvacorts merged commit ab2721d into main Nov 11, 2024
57 checks passed
@salvacorts salvacorts deleted the salvacorts/minor-fixes-planner branch November 11, 2024 11:17
@salvacorts salvacorts added type/bug Somehing is not working as expected backport k227 labels Nov 14, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k227 size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants