Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Downgrade hyperloglog to 0.2.0 #15424

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(deps): Downgrade hyperloglog to 0.2.0 #15424

merged 2 commits into from
Dec 16, 2024

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Dec 16, 2024 •
edited
Loading

What this PR does / why we need it:
Publish images are failing on loki with error

180.2 vendor/github.com/kamstrup/intmap/map64.go:22:11: 0x9E3779B9 (untyped int constant 2654435769) overflows int

this should fix it.
Reverts: #15322

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@shantanualsi shantanualsi marked this pull request as ready for review December 16, 2024 08:48
@shantanualsi shantanualsi requested a review from a team as a code owner December 16, 2024 08:48
@chaudum chaudum merged commit 4077196 into k233 Dec 16, 2024
63 checks passed
@chaudum chaudum deleted the shantanu/k233-downgrade-hyperloglog branch December 16, 2024 09:52
chaudum pushed a commit that referenced this pull request Dec 16, 2024
@shantanualsi @chaudum
fix(deps): Downgrade hyperloglog to 0.2.0 (#15424)
976a5a5
chaudum added a commit that referenced this pull request Dec 16, 2024
@chaudum @shantanualsi
fix(deps): Downgrade hyperloglog to 0.2.0 (#15424) (#15426)
3b0d815 
Co-authored-by: Shantanu Alshi <[email protected]>
This was referenced Dec 23, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 6, 2025
Open
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
@chaudum @shantanualsi @mveitas
fix(deps): Downgrade hyperloglog to 0.2.0 (grafana#15424) (grafana#15426
8b171a6 
)

Co-authored-by: Shantanu Alshi <[email protected]>
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 13, 2025
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jan 20, 2025
Open
This was referenced Feb 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shantanualsi @chaudum