Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs feedback: /operations/storage/logs-deletion.md #4183

Closed
michaelkebe opened this issue Aug 18, 2021 · 3 comments
Closed

Docs feedback: /operations/storage/logs-deletion.md #4183

michaelkebe opened this issue Aug 18, 2021 · 3 comments

Comments

@michaelkebe
Copy link

The example curl command to Request log entry deletion does not work.

curl -X POST 'http://localhost:3100/loki/api/admin/delete?match[]={host="myhost"}'
1:5: parse error: unexpected "="

I got it working with escaping the curly braces with %7B and %7D.

curl -X POST 'http://localhost:3100/loki/api/admin/delete?match[]=%7Bhost="myhost"}%7D

I am using curl version:

$ curl --version
curl 7.58.0 (x86_64-pc-linux-gnu) libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Release-Date: 2018-01-24

Please change the documentation to use url encoded curly braces. Maybe I am missing something with the usage of curl. Looks like curl doesn't like curly braces. 😄

@stale
Copy link

stale bot commented Sep 19, 2021

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 19, 2021
@michaelkebe
Copy link
Author

Documentation is still wrong about this.

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Sep 20, 2021
@KMiller-Grafana
Copy link
Contributor

The documentation for the next-to-be-released version of Loki has a fix for this issue which URL encodes the brackets and braces. The PR that made the fix: #4294.

Since a fix has been made, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants