Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure user assigned managed identity #5710

Closed
stevehipwell opened this issue Mar 25, 2022 · 2 comments · Fixed by #5891
Closed

Add support for Azure user assigned managed identity #5710

stevehipwell opened this issue Mar 25, 2022 · 2 comments · Fixed by #5891
Labels
component/storage type/feature Something new we should do

Comments

@stevehipwell
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We can't configure Loki running in a Kubernetes cluster with a user assigned managed identity to access an Azure storage account. We use aad-pod-identity to give services their identity in our AKS clusters, much like IRSA in EKS, and need Loki to support this.

Describe the solution you'd like
Allow the user to provide the user assigned identity id when configuring the Azure storage settings.

Describe alternatives you've considered
n/a

Additional context
The current Azure package versions should support this based on the Thanos implementation. @Ottovsky mentioned this in #4256.

@stale
Copy link

stale bot commented Apr 25, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Apr 25, 2022
@stevehipwell
Copy link
Contributor Author

This issue isn't stale, there is an open PR to fix it.

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/storage type/feature Something new we should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants