ksonnet: do not deploy table manager when shipper is in-use #11020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
approved these changes
Oct 26, 2023
CHANGELOG.md
Outdated
| @@ -69,6 +69,8 @@ | |||
|
|
|||
| #### Jsonnet | |||
|
|
|||
| * [11020](https://github.com/grafana/loki/pull/11020) **ashwanthgoli**: Do not generate table-manager manifests if shipper store is in-use. | |||
There was a problem hiding this comment.
Seems very generic. May be let's make sure it's for Loki ksonnet deployment?
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…11020) **What this PR does / why we need it**: Do not generate table manager manifests if shipper is being used. table manager is a deprecated target and is not recommended when using `tsdb` or `boltdb-shipper` indexes. Compactor is already bunlded along with shipper and handles retention, compaction for the `tsdb` and `boltb-shipper` indexes **Which issue(s) this PR fixes**: Fixes [grafana#10943](grafana#10943) **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. <!-- TODO(salvacorts): Add example PR -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Do not generate table manager manifests if shipper is being used.
table manager is a deprecated target and is not recommended when using
tsdborboltdb-shipperindexes.Compactor is already bunlded along with shipper and handles retention, compaction for the
tsdbandboltb-shipperindexesWhich issue(s) this PR fixes:
Fixes #10943
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory.