Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StoreGateway IndexHeader configurations to indexheader.Config #5727

Closed
lamida opened this issue Aug 14, 2023 · 0 comments · Fixed by #5726
Closed

Move StoreGateway IndexHeader configurations to indexheader.Config #5727

lamida opened this issue Aug 14, 2023 · 0 comments · Fixed by #5726
Assignees
@lamida

Comments

@lamida
Copy link
Contributor

lamida commented Aug 14, 2023

Would it make sense to move these options to indexheader.Config? IMO it's clearer to have IndexHeader.LazyLoadingEnabled, and would also reduce the number of args in some calls, etc.

Originally posted by @colega in #5596 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamida lamida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Index Header Configs grafana/mimir
1 participant
@lamida