Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbound submission webhook API should return some identifiers #3912

Closed
mjs opened this issue Feb 19, 2024 · 3 comments
Closed

Inbound submission webhook API should return some identifiers #3912

mjs opened this issue Feb 19, 2024 · 3 comments

Comments

@mjs
Copy link

mjs commented Feb 19, 2024

What would you like to see!

When an alert is submitted to inbound integration webhook API (i.e. the formatted webhook), the response is simply a plain text Ok. This makes it difficult to find the identifying details for the alert via the OnCall API.

We have an internal alerting system where urgent alerts are synchronised to OnCall. The OnCall alert group id is stored in our internal system after the alert has been submitted to OnCall. What we are doing now is quite convoluted:

  1. Submit the alert using a formatted webhook call. We include an internal id in the alert details.
  2. Make a OnCall alert search API call using the internal id to find the OnCall alert details.
  3. Make another OnCall API request to map the alert id to the alert group id.
  4. Store the alert group id against the alert in our internal system.

It would be much more efficient if the formatted webhook API returned the alert id and alert group id at submission time.

Product Area

Alert Flow & Configuration

Anything else to add?

No response

@mjs mjs added the feature request New feature or request label Feb 19, 2024
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.105. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@joeyorlando
Copy link
Contributor

hi there @mjs 👋

have you considered setting up an Outgoing Webhook with the "Alert Group Created" event type? (docs)

We don't have any plans to modify the response for incoming alerts. This is because the actual alert creation is done asynchronously. Therefore it is not possible to know these ids at response time.

@mjs
Copy link
Author

mjs commented Feb 25, 2024

Thanks. I figured this might be what was going on. I'll take a look at Outgoing Webhooks.

@mjs mjs closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants