From 5baac6bda27c9001450892a2d21b2733fa643719 Mon Sep 17 00:00:00 2001 From: Joey Orlando Date: Tue, 20 Aug 2024 15:10:09 -0400 Subject: [PATCH 1/4] update go toolchain version to use the 1.N.P syntax --- grafana-plugin/go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grafana-plugin/go.mod b/grafana-plugin/go.mod index a905ffd3eb..f059ec7554 100644 --- a/grafana-plugin/go.mod +++ b/grafana-plugin/go.mod @@ -1,6 +1,6 @@ module github.com/grafana-labs/grafana-oncall-app -go 1.21 +go 1.21.5 require github.com/grafana/grafana-plugin-sdk-go v0.228.0 From 12b708aa8683f4745b0fbf3825aeb120dba89589 Mon Sep 17 00:00:00 2001 From: Joey Orlando Date: Tue, 20 Aug 2024 15:36:09 -0400 Subject: [PATCH 2/4] typo --- .github/workflows/snyk-security-scan.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk-security-scan.yml b/.github/workflows/snyk-security-scan.yml index 9611de3669..0d224e3063 100644 --- a/.github/workflows/snyk-security-scan.yml +++ b/.github/workflows/snyk-security-scan.yml @@ -4,7 +4,7 @@ on: workflow_call: jobs: - snyk-python-security-scan: + snyk-security-scan: name: Snyk security scan runs-on: ubuntu-latest # see this PR regarding the permissions needed for this workflow From e2fa95502bb69f7c4caa875a8fa7fec7a371d23a Mon Sep 17 00:00:00 2001 From: Joey Orlando Date: Tue, 20 Aug 2024 15:52:14 -0400 Subject: [PATCH 3/4] add comment --- .github/workflows/snyk-security-scan.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/snyk-security-scan.yml b/.github/workflows/snyk-security-scan.yml index 0d224e3063..e4758f40be 100644 --- a/.github/workflows/snyk-security-scan.yml +++ b/.github/workflows/snyk-security-scan.yml @@ -40,3 +40,7 @@ jobs: # yamllint enable rule:line-length env: SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} + # TODO: setup snyk container monitor & snyk container test + # will require building the docker image and storing it in the local docker registry.. + # will need to refactor .github/workflows/build-engine-docker-image-and-publish-to-dockerhub.yml + # to be a composable action instead of a workflow From c93b2cb2d6d23d2172ac2d053f9abc67fa35684f Mon Sep 17 00:00:00 2001 From: Joey Orlando Date: Tue, 20 Aug 2024 16:34:13 -0400 Subject: [PATCH 4/4] wip --- .github/workflows/snyk-security-scan.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/snyk-security-scan.yml b/.github/workflows/snyk-security-scan.yml index e4758f40be..9611de3669 100644 --- a/.github/workflows/snyk-security-scan.yml +++ b/.github/workflows/snyk-security-scan.yml @@ -4,7 +4,7 @@ on: workflow_call: jobs: - snyk-security-scan: + snyk-python-security-scan: name: Snyk security scan runs-on: ubuntu-latest # see this PR regarding the permissions needed for this workflow @@ -40,7 +40,3 @@ jobs: # yamllint enable rule:line-length env: SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} - # TODO: setup snyk container monitor & snyk container test - # will require building the docker image and storing it in the local docker registry.. - # will need to refactor .github/workflows/build-engine-docker-image-and-publish-to-dockerhub.yml - # to be a composable action instead of a workflow